DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=UuFBIwFt4G2vZMVYmvZ5x5xYN3IpbkHYHFYIuaQ8mXmJeTbTC6yUPk95SQd9xE3nB3
         yqs8Y3ND9DXdZtFLcP0sAVEccHEVlhbLKWw7E4TzQoc95d60XLX8KReyYe/2LPJVNWrB
         giEI+IbYEt26gTxLkeZREI2PWPehi8k/hUpcc=
MIME-Version: 1.0
In-Reply-To: <20100114084659.D713.A69D9226@jp.fujitsu.com>
References: <20100113171953.B3E5.A69D9226@jp.fujitsu.com>
	 <28c262361001130231k29b933der4022f4d1da80b084@mail.gmail.com>
	 <20100114084659.D713.A69D9226@jp.fujitsu.com>
Date: Thu, 14 Jan 2010 14:12:25 +0900
Message-ID: <28c262361001132112i7f50fd66qcd24dc2ddb4d78d8@mail.gmail.com>
Subject: Re: [PATCH 2/3][v2] vmstat: add anon_scan_ratio field to zoneinfo
From: Minchan Kim <minchan.kim@gmail.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-mm <linux-mm@kvack.org>,
       Andrew Morton <akpm@linux-foundation.org>,
       Balbir Singh <balbir@linux.vnet.ibm.com>,
       KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
       Rik van Riel <riel@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1210
Lines: 37

On Thu, Jan 14, 2010 at 8:50 AM, KOSAKI Motohiro
<kosaki.motohiro@jp.fujitsu.com> wrote:
> Hi
>
>> Hi, Kosaki.
>>
>> On Wed, Jan 13, 2010 at 5:21 PM, KOSAKI Motohiro
>> <kosaki.motohiro@jp.fujitsu.com> wrote:
>> > Changelog
>> >  from v1
>> >  - get_anon_scan_ratio don't tak zone->lru_lock anymore
>> >   because zoneinfo_show_print takes zone->lock.
>>
>> When I saw this changelog first, I got confused.
>> That's because there is no relation between lru_lock and lock in zone.
>> You mean zoneinfo is allowed to have a stale data?
>> Tend to agree with it.
>
> Well. zone->lock and zone->lru_lock should be not taked at the same time.

I looked over the code since I am out of office.
I can't find any locking problem zone->lock and zone->lru_lock.
Do you know any locking order problem?
Could you explain it with call graph if you don't mind?

I am out of office by tomorrow so I can't reply quickly.
Sorry for late reponse.


-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/