Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756154Ab0ANLD5 (ORCPT ); Thu, 14 Jan 2010 06:03:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756119Ab0ANLD4 (ORCPT ); Thu, 14 Jan 2010 06:03:56 -0500 Received: from one.firstfloor.org ([213.235.205.2]:43491 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756106Ab0ANLD4 (ORCPT ); Thu, 14 Jan 2010 06:03:56 -0500 Date: Thu, 14 Jan 2010 12:03:54 +0100 From: Andi Kleen To: Alan Cox Cc: Andi Kleen , Greg KH , Tilman Schmidt , Stephen Rothwell , LKML , netdev@vger.kernel.org, Karsten Keil , isdn4linux@listserv.isdn4linux.de Subject: Re: Can we remove pci_find_device() yet? Message-ID: <20100114110354.GJ12241@basil.fritz.box> References: <20100108112236.462a3da2.sfr@canb.auug.org.au> <20100108044646.GC6611@suse.de> <4B4B802A.2010709@imap.cc> <20100111200136.GA29955@suse.de> <877hrlf0rf.fsf@basil.nowhere.org> <20100114110214.37d7ffc9@lxorguk.ukuu.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100114110214.37d7ffc9@lxorguk.ukuu.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 774 Lines: 20 On Thu, Jan 14, 2010 at 11:02:14AM +0000, Alan Cox wrote: > > e.g. set some global variable that forbids device removal > > and warn in the kernel log. In theory this could be also > > done per device, but I guess that would be more effort. > > There is a simpler way to do that, which is to just leak a reference in > the hisax_find_pci_device hack. The pci_dev won't be going anywhere then. You just have to do it once, otherwise it'll fail after 4 billion times. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/