From: Jean Delvare <jdelvare@suse.de>
Organization: SuSE Linux
To: minyard@acm.org
Subject: Re: [PATCH] IPMI: Add parameter to limit CPU usage in kipmid
Date: Thu, 14 Jan 2010 15:02:18 +0100
User-Agent: KMail/1.9.1
Cc: Andrew Morton <akpm@linux-foundation.org>,
       Linux Kernel <linux-kernel@vger.kernel.org>,
       Martin Wilck <martin.wilck@ts.fujitsu.com>,
       OpenIPMI Developers <openipmi-developer@lists.sourceforge.net>
References: <20091216212354.GA13097@minyard.local> <20091217220821.GA4513@minyard.local> <200912191456.04950.jdelvare@suse.de>
In-Reply-To: <200912191456.04950.jdelvare@suse.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Message-Id: <201001141502.18720.jdelvare@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1432
Lines: 35

Le samedi 19 d?cembre 2009 14:56, Jean Delvare a ?crit?:
> Le jeudi 17 d?cembre 2009 23:08, Corey Minyard a ?crit?:
> > I cleaned up the patch some.  I added some state results to the list of
> > things to be busy waited for (should improve performance a bit) and
> > changed the schedule_timeout_interruptible back to 1, since that's
> > what it's supposed to be.  And I added some comments.
> 
> Thanks for doing this!
> 
> > I did some testing on my system here.  On my system, kipmid uses almost
> > no CPU normally.  If I set the kipmid_max_busy_us value to 500, the
> > interface was more than 5 times slower.  I had to set the value up to
> > 35000 for it to go back to the normal performance, and it was pretty
> > linear between the two values.  So this is definiately not for all
> > systems.
> > 
> > Can you try this out to make sure its ok?
> 
> I don't have any hardware where I can test this myself. But hopefully
> Martin does?

I've had the latest version of this patch tested by one of my
colleagues who has access to the relevant hardware, results are OK.
So I think we're ready to go, can we finally have this patch pushed
upstream?

Thanks,
-- 
Jean Delvare
Suse L3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/