Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756930Ab0ANPD3 (ORCPT ); Thu, 14 Jan 2010 10:03:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756879Ab0ANPCO (ORCPT ); Thu, 14 Jan 2010 10:02:14 -0500 Received: from mail-iw0-f194.google.com ([209.85.223.194]:56322 "EHLO mail-iw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756837Ab0ANPCG (ORCPT ); Thu, 14 Jan 2010 10:02:06 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=Ukfs6nSo35c9WhQXD3ev+DOmT5a+grtd6SJT+q5eLzOQBzA+oH6FPz8RVq5EnjK4z9 dAoeqzysx/VVtvG+mGGbZo8syDHcMiPuwZ02YQxK5Zn0d9eyNnap3dTr4dUFJtkZEL2+ de6TjqUesWxGW8xbs4+lCaJzjr/UDfuCHM8NI= Message-ID: <4B4F31EB.1000004@gmail.com> Date: Thu, 14 Jan 2010 10:02:03 -0500 From: William Allen Simpson User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) MIME-Version: 1.0 To: Patrick McHardy CC: Joe Perches , Andi Kleen , Linux Kernel Developers , Linux Kernel Network Developers , =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= , Eric Dumazet Subject: Re: [PATCH v4] tcp: harmonize tcp_vx_rcv header length assumptions References: <4B49D001.4000302@gmail.com> <4B4DA4F4.6060007@gmail.com> <20100113115617.GA24818@basil.fritz.box> <4B4DE887.6030602@gmail.com> <20100113155323.GB24818@basil.fritz.box> <4B4E23E0.4000007@gmail.com> <4B4E378A.7040506@gmail.com> <1263430990.1966.12.camel@Joe-Laptop.home> <4B4ED830.4040407@trash.net> In-Reply-To: <4B4ED830.4040407@trash.net> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1003 Lines: 24 Patrick McHardy wrote: > In IPv6 it is released in ip6_input.c before the packet is handed to > the protocol handler. > Thanks, I made a note of it. Thanks to Andi, I've been using his suggestion to compare the IPv4 and IPv6 generated code. Another minor difference between them was IPv4 stored *iph. So, I added *ip6h, and discovered that it made the code longer. Later inline function invocations had also calculated it, so adding it merely calculated it earlier and stored it. The code thrashes registers making room for the additional variable. I'm guessing that the IPv6 folks had already looked at the issue.... Good work! So, I tried removing *iph, and that shrunk the IPv4 code some, too. Thanks to everybody for their comments and review. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/