Date: Thu, 14 Jan 2010 17:18:26 +0100
Message-ID: <s5hd41ck6ct.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: alsa-devel@alsa-project.org, ibm-acpi@hmh.eng.br,
       Jaroslav Kysela <perex@perex.cz>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] alsa: use subsys_initcall for sound core instead of module_init
In-Reply-To: <20100114155342.GA1396@holoscopio.com>
References: <1263334840-6118-1-git-send-email-cascardo@holoscopio.com>
	<s5h63765wm0.wl%tiwai@suse.de>
	<20100114155342.GA1396@holoscopio.com>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1295
Lines: 38

At Thu, 14 Jan 2010 13:53:43 -0200,
Thadeu Lima de Souza Cascardo wrote:
> 
> On Wed, Jan 13, 2010 at 07:48:07AM +0100, Takashi Iwai wrote:
> > At Tue, 12 Jan 2010 20:20:39 -0200,
> > Thadeu Lima de Souza Cascardo wrote:
> > > 
> > > This is needed for built-in drivers which are built before the sound directory,
> > > like thinkpad_acpi.
> > > 
> > > Otherwise, registering a card fails.
> > 
> > Oh well, this kind of problem hits again.
> > 
> > I don't remember why subsys_init() wasn't taken before...  Maybe some
> > dependency between sound and V4L or so.  But, it's worth to check again.
> > 
> 
> Any references to this dependency problem, so I can try to help and investigate
> about it and do some tests?

I also don't remember.  That was a long long ago... :)

> > I'll apply this after some testing.
> > 
> 
> Built-in thinkpad-acpi started working for me after these changes. I can't tell
> you about any subsystem that stopped working, like some V4L driver.

Did you test whether the sound subsystem still works as modules?


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/