Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757480Ab0ANTTK (ORCPT ); Thu, 14 Jan 2010 14:19:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757366Ab0ANTTJ (ORCPT ); Thu, 14 Jan 2010 14:19:09 -0500 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:34052 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932297Ab0ANTTI (ORCPT ); Thu, 14 Jan 2010 14:19:08 -0500 Date: Thu, 14 Jan 2010 19:22:10 +0000 From: Alan Cox To: Bartlomiej Zolnierkiewicz Cc: Krzysztof Halasa , linux-ide@vger.kernel.org, lkml Subject: Re: SATA_SIL on IXP425 workaround Message-ID: <20100114192210.62593ead@lxorguk.ukuu.org.uk> In-Reply-To: <201001141659.19687.bzolnier@gmail.com> References: <201001141659.19687.bzolnier@gmail.com> X-Mailer: Claws Mail 3.7.3 (GTK+ 2.18.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 687 Lines: 14 > FWIW your patch is now in my atang tree (I'm aware that Jeff is working > on generic solution but in the meantime this non-intrusive patch allows > sata_sil to work on IXP425). I think this is the wrong place. If your platform can't do MMIO properly then the platform pci_iomap or pci quirk code should do the needed cleaning up, not put turds into the drivers. Why not just quirk it on your specific platform and clear the MMIO mapping. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/