DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=E6guVRkRpvWdFv66b+9Wp7DmJbQoPi2pnOg6HFFu/af9giRYnv7k4kf6+Jd7wI8qlb
         Lcfou7VZq4w1qiZi17lVBEo/1YuWYNQVgeJf+RK3jUQNnFUImRL0Cn9+8UCgeAZbFQfP
         OwZDnBtiwgeCpO8OuP2WGY2SjN/r4tBKatjkY=
Date: Sun, 17 Jan 2010 15:12:35 +0100
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Stephane Eranian <eranian@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org,
       mingo@elte.hu, paulus@samba.org, davem@davemloft.net,
       perfmon2-devel@lists.sf.net
Subject: Re: [PATCH] perf_events: improve x86 event scheduling
Message-ID: <20100117141233.GF5035@nowhere>
References: <4b4c761b.0338560a.1eaa.ffff824d@mx.google.com> <1263312616.4244.153.camel@laptop> <bd4cb8901001130154p732672b6x56e758c1ab33a8e8@mail.gmail.com> <1263400193.4244.238.camel@laptop> <bd4cb8901001130852y1de007cbqe66d77605c1ec372@mail.gmail.com> <bd4cb8901001130922s7ad85af6w6c631d90de177ef9@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bd4cb8901001130922s7ad85af6w6c631d90de177ef9@mail.gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1101
Lines: 42

On Wed, Jan 13, 2010 at 06:22:54PM +0100, Stephane Eranian wrote:
> Ok,
> 
> Something like that should problably do it:
> 
> static void event_sched_out(struct perf_event *event, int cpu)
> {
>         event->state = PERF_EVENT_STATE_INACTIVE;
>         event->oncpu = -1;
> }


You need to also call pmu->disable() if it is a software event,
because a breakpoint needs to be unregistered in hardware level
too.

And disable it in x86 level if it is an x86 event?


> hw_perf_group_sched_in()
> {
>        ....
>        n = 1;
>         list_for_each_entry(sub, &leader->sibling_list, group_entry) {
>                 if (sub->state > PERF_EVENT_STATE_OFF) {
>                         ret = event_sched_in(sub, cpu);
>                         if (ret)
>                                 goto undo;


Yeah we indeed really need to check that.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/