Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754616Ab0AQUOa (ORCPT ); Sun, 17 Jan 2010 15:14:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751118Ab0AQUO2 (ORCPT ); Sun, 17 Jan 2010 15:14:28 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:34284 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750922Ab0AQUO0 (ORCPT ); Sun, 17 Jan 2010 15:14:26 -0500 Message-ID: <4B536FFF.9060509@gmail.com> Date: Sun, 17 Jan 2010 21:15:59 +0100 From: Emese Revfy User-Agent: Thunderbird 2.0.0.23 (X11/20090812) MIME-Version: 1.0 To: Al Viro CC: linux-kernel@vger.kernel.org, teigland@redhat.com, Matt_Domsch@dell.com, maciej.sosnowski@intel.com, hjk@linutronix.de, Pekka Enberg , jens.axboe@oracle.com, shemminger@vyatta.com, akpm@linux-foundation.org, davem@davemloft.net, torvalds@linux-foundation.org, netdev@vger.kernel.org, Greg KH Subject: Re: [PATCH 1/1] Constify struct sysfs_ops for v2.6.33-rc4 References: <4B5338D6.2050209@gmail.com> <20100117182537.GQ19799@ZenIV.linux.org.uk> <20100117182906.GR19799@ZenIV.linux.org.uk> In-Reply-To: <20100117182906.GR19799@ZenIV.linux.org.uk> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-ELTE-SpamScore: 0.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=0.0 required=5.9 tests=none autolearn=no SpamAssassin version=3.2.5 _SUMMARY_ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1416 Lines: 36 Al Viro wrote: > On Sun, Jan 17, 2010 at 06:25:37PM +0000, Al Viro wrote: >> On Sun, Jan 17, 2010 at 05:20:38PM +0100, Emese Revfy wrote: >> >>> Signed-off-by: Emese Revfy >>> Acked-by: David Teigland >>> Acked-by: Matt Domsch >>> Acked-by: Maciej Sosnowski >>> Acked-by: Hans J. Koch >>> Acked-by: Pekka Enberg >>> Acked-by: Jens Axboe >>> Acked-by: Stephen Hemminger >> NACKed-by: Al Viro >> >> Same reason. > > BTW, commit 9905a43b2d563e6f89e4c63c4278ada03f2ebb14 > Author: Emese Revfy > Date: Mon Dec 14 00:58:57 2009 +0100 > > backlight: Constify struct backlight_ops > > is also crap; again, same reason. Would you please get a clue and stop > pushing that particular bullshit into the tree? The backlight maintainer accepted that patch before the discussion on field constification concluded. I drew his attention to the discussion (http://lkml.org/lkml/2009/12/16/395) but he still accepted the patch as is. -- Emese -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/