Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755045Ab0AQVxx (ORCPT ); Sun, 17 Jan 2010 16:53:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753934Ab0AQVxu (ORCPT ); Sun, 17 Jan 2010 16:53:50 -0500 Received: from smtp-out.google.com ([216.239.33.17]:2603 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754099Ab0AQVxt convert rfc822-to-8bit (ORCPT ); Sun, 17 Jan 2010 16:53:49 -0500 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=mime-version:in-reply-to:references:date:message-id:subject:from:to: cc:content-type:content-transfer-encoding:x-system-of-record; b=jFdawXBkVvjdIuxxGHs21AHJaDvBrj+vdPPwDXMkiY7DMRKGvX/pEFwlZCHqaLJWs sWAnAPwCxNmtuaPAqit1A== MIME-Version: 1.0 In-Reply-To: <20100117161859.GG5035@nowhere> References: <4b4c761b.0338560a.1eaa.ffff824d@mx.google.com> <1263312616.4244.153.camel@laptop> <1263400193.4244.238.camel@laptop> <20100117141233.GF5035@nowhere> <20100117161859.GG5035@nowhere> Date: Sun, 17 Jan 2010 22:53:43 +0100 Message-ID: Subject: Re: [PATCH] perf_events: improve x86 event scheduling From: Stephane Eranian To: Frederic Weisbecker Cc: Peter Zijlstra , linux-kernel@vger.kernel.org, mingo@elte.hu, paulus@samba.org, davem@davemloft.net, perfmon2-devel@lists.sf.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2548 Lines: 85 hi, Will repost a new version of the patch with these changes. On Sun, Jan 17, 2010 at 5:19 PM, Frederic Weisbecker wrote: > On Sun, Jan 17, 2010 at 03:42:16PM +0100, Stephane Eranian wrote: >> Frederic, >> >> >> Here is what I have now in the x86 code. >> >> As for your comment on disabling the x86 event, we don't >> need to do this because it is not actually activated yet when >> we return from hw_perf_group_sched_in(). Activation occurs >> really in hw_perf_enable(). > > > Ah, indeed. > > >> >> >> static int x86_event_sched_in(struct perf_event *event, >>                           struct perf_cpu_context *cpuctx, int cpu) >> { >>         int ret = 0; >> >>         event->state = PERF_EVENT_STATE_ACTIVE; >>         event->oncpu = cpu; >>         event->tstamp_running += event->ctx->time - event->tstamp_stopped; >> >>         if (is_software_event(event)) >>                 ret = event->pmu->enable(event); >> >>         if (!ret && !is_software_event(event)) >>                 cpuctx->active_oncpu++; >> >>         if (!ret && event->attr.exclusive) >>                 cpuctx->exclusive = 1; >> >>         return ret; >> } >> >> static void x86_event_sched_out(struct perf_event *event, >>                             struct perf_cpu_context *cpuctx, int cpu) >> { >>         event->state = PERF_EVENT_STATE_INACTIVE; >>         event->oncpu = -1; >> >>         event->tstamp_running -= event->ctx->time - event->tstamp_stopped; >> >>         if (is_software_event(event)) >>                 event->pmu->disable(event); >> >>         if (!is_software_event(event)) >>                 cpuctx->active_oncpu--; >> >>         if (event->attr.exclusive || !cpuctx->active_oncpu) >>                 cpuctx->exclusive = 0; >> } > > > > Yeah looks good. > > Thanks. > > -- Stephane Eranian | EMEA Software Engineering Google France | 38 avenue de l'Opéra | 75002 Paris Tel : +33 (0) 1 42 68 53 00 This email may be confidential or privileged. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it went to the wrong person. Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/