Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752155Ab0ARGBs (ORCPT ); Mon, 18 Jan 2010 01:01:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751033Ab0ARGBq (ORCPT ); Mon, 18 Jan 2010 01:01:46 -0500 Received: from casper.infradead.org ([85.118.1.10]:47258 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750720Ab0ARGBp (ORCPT ); Mon, 18 Jan 2010 01:01:45 -0500 Date: Sun, 17 Jan 2010 22:01:30 -0800 From: Arjan van de Ven To: Tejun Heo Cc: torvalds@linux-foundation.org, mingo@elte.hu, peterz@infradead.org, awalls@radix.net, linux-kernel@vger.kernel.org, jeff@garzik.org, akpm@linux-foundation.org, jens.axboe@oracle.com, rusty@rustcorp.com.au, cl@linux-foundation.org, dhowells@redhat.com, avi@redhat.com, johannes@sipsolutions.net, andi@firstfloor.org, Tejun Heo , Arjan van de Ven Subject: Re: [PATCH 32/40] async: introduce workqueue based alternative implementation Message-ID: <20100117220130.214d56f1@linux.intel.com> In-Reply-To: <1263776272-382-33-git-send-email-tj@kernel.org> References: <1263776272-382-1-git-send-email-tj@kernel.org> <1263776272-382-33-git-send-email-tj@kernel.org> Organization: Intel X-Mailer: Claws Mail 3.7.3 (GTK+ 2.16.6; i586-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1079 Lines: 28 On Mon, 18 Jan 2010 09:57:44 +0900 Tejun Heo wrote: > Now that cmwq can handle high concurrency, there's no reason to > implement separate thread pool for async. Introduce alternative > implementation based on workqueue. > I'm sorry but I'm really not happy with this conversion; it looses the very nice property of being able to execute and synchronize between places at the end just before device registration. I don't mind the implementation sharing thread pool with your stuff, but I really really want to keep the cookie and synchronization mechanism. There's a bunch of users of that pending and doing things sequential entirely just is not going to cut it. -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/