Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754073Ab0ARLNk (ORCPT ); Mon, 18 Jan 2010 06:13:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754029Ab0ARLNj (ORCPT ); Mon, 18 Jan 2010 06:13:39 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:44006 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754015Ab0ARLNj (ORCPT ); Mon, 18 Jan 2010 06:13:39 -0500 Subject: Re: [PATCH] perf_events: improve x86 event scheduling From: Peter Zijlstra To: Frederic Weisbecker Cc: Stephane Eranian , linux-kernel@vger.kernel.org, mingo@elte.hu, paulus@samba.org, davem@davemloft.net, perfmon2-devel@lists.sf.net In-Reply-To: <20100117141233.GF5035@nowhere> References: <4b4c761b.0338560a.1eaa.ffff824d@mx.google.com> <1263312616.4244.153.camel@laptop> <1263400193.4244.238.camel@laptop> <20100117141233.GF5035@nowhere> Content-Type: text/plain; charset="UTF-8" Date: Mon, 18 Jan 2010 12:13:09 +0100 Message-ID: <1263813189.4283.245.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 527 Lines: 15 On Sun, 2010-01-17 at 15:12 +0100, Frederic Weisbecker wrote: > You need to also call pmu->disable() if it is a software event, > because a breakpoint needs to be unregistered in hardware level > too. breakpoint isn't a software pmu. But yeah, enable and disable need to match. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/