Message-ID: <4B54445E.302@kernel.org>
Date: Mon, 18 Jan 2010 20:22:06 +0900
From: Tejun Heo <tj@kernel.org>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091130 SUSE/3.0.0-1.1.1 Thunderbird/3.0
MIME-Version: 1.0
To: Peter Zijlstra <peterz@infradead.org>
CC: torvalds@linux-foundation.org, mingo@elte.hu, awalls@radix.net,
       linux-kernel@vger.kernel.org, jeff@garzik.org,
       akpm@linux-foundation.org, jens.axboe@oracle.com, rusty@rustcorp.com.au,
       cl@linux-foundation.org, dhowells@redhat.com, arjan@linux.intel.com,
       avi@redhat.com, johannes@sipsolutions.net, andi@firstfloor.org,
       Mike Galbraith <efault@gmx.de>
Subject: Re: [PATCH 04/40] sched: implement __set_cpus_allowed()
References: <1263776272-382-1-git-send-email-tj@kernel.org>	 <1263776272-382-5-git-send-email-tj@kernel.org> <1263808570.4283.149.camel@laptop>
In-Reply-To: <1263808570.4283.149.camel@laptop>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1160
Lines: 29

On 01/18/2010 06:56 PM, Peter Zijlstra wrote:
>> NOTE: It would be nice to implement kthread_bind() in terms of
>>       __set_cpus_allowed() if we can drop the capability to bind to a
>>       dead CPU from kthread_bind(), which doesn't seem too popular
>>       anyway.  With such change, we'll have set_cpus_allowed_ptr() for
>>       regular tasks and kthread_bind() for kthreads and can use
>>       PF_THREAD_BOUND instead of passing @force parameter around.
> 
> 
> And your changelog still sucks... it only says what it does, not why.
> 
> still hate the patch too.

These part haven't changed at all since the last posting so if you
disliked it before it's kind of expected you still do so.

Anyways, I'm not the greatest fan of this patch either.  Let's see how
the whole series fares out first and try to make this better.  What do
you think about doing what's described in the NOTE?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/