Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755331Ab0ARRnT (ORCPT ); Mon, 18 Jan 2010 12:43:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754729Ab0ARRnS (ORCPT ); Mon, 18 Jan 2010 12:43:18 -0500 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:37212 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753988Ab0ARRnR (ORCPT ); Mon, 18 Jan 2010 12:43:17 -0500 Date: Mon, 18 Jan 2010 17:46:02 +0000 From: Alan Cox To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/64] pata_ali: cleanup ali_set_piomode() Message-ID: <20100118174602.47f8ec24@lxorguk.ukuu.org.uk> In-Reply-To: <20100118171412.14623.94854.sendpatchset@localhost> References: <20100118171349.14623.90030.sendpatchset@localhost> <20100118171412.14623.94854.sendpatchset@localhost> X-Mailer: Claws Mail 3.7.3 (GTK+ 2.18.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 753 Lines: 19 On Mon, 18 Jan 2010 18:14:12 +0100 Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz > Subject: [PATCH] pata_ali: cleanup ali_set_piomode() > > Merge ali_fifo_control() calls. This also changes the behaviour. The old driver, reference code and old IDE driver (at least at the time I did pata_ali) all did the fifo off case, then the mode change, then the FIFO on case. I don't see why it should matter but it ought to be noted in the changelog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/