DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=from:to:subject:date:user-agent:cc:references:in-reply-to
         :mime-version:content-type:content-transfer-encoding:message-id;
        b=Dzgl+WRNRvBufGrROXqQCh8vlj0fZWY5ExqJ+KuDV7XzLIDDkQj/4WpJ3I3U8Q+Mfm
         zNt+3UKq0iZfN2qHbQ8dvLYuEtD24FxGbm07IDlu6HFM5YbAan8sgZ39+N8m3JhaY8Sx
         uWBc5KxPruk10RqRAPQqVKPsH/foonrDnl2Qs=
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH 01/64] libata: fix CFA handling in ide_timing_compute()
Date: Mon, 18 Jan 2010 20:04:39 +0100
User-Agent: KMail/1.12.2 (Linux/2.6.31.8-0.1-desktop; KDE/4.3.1; x86_64; ; )
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20100118171349.14623.90030.sendpatchset@localhost> <201001181929.17136.bzolnier@gmail.com> <4B54AF06.3060800@ru.mvista.com>
In-Reply-To: <4B54AF06.3060800@ru.mvista.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201001182004.40031.bzolnier@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2007
Lines: 55

On Monday 18 January 2010 07:57:10 pm Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
> 
> >>> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> >>> Subject: [PATCH] libata: fix CFA handling in ide_timing_compute()
> >>>
> >>> Use standard cycle timing for CFA PIO5 and PIO6 modes.
> >>>
> >>> Based on commit 74638c8 for IDE subsystem.
> >>>
> >>> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> >>> ---
> >>>  drivers/ata/libata-core.c |   17 +++++++++++------
> >>>  1 file changed, 11 insertions(+), 6 deletions(-)
> >>>
> >>> Index: b/drivers/ata/libata-core.c
> >>> ===================================================================
> >>> --- a/drivers/ata/libata-core.c
> >>> +++ b/drivers/ata/libata-core.c
> >>> @@ -3211,6 +3211,7 @@ const struct ata_timing *ata_timing_find
> >>>  int ata_timing_compute(struct ata_device *adev, unsigned short speed,
> >>>  		       struct ata_timing *t, int T, int UT)
> >>>  {
> >>> +	const u16 *id = adev->id;
> >>>  	const struct ata_timing *s;
> >>>  	struct ata_timing p;
> >>>  
> >>> @@ -3228,14 +3229,18 @@ int ata_timing_compute(struct ata_device
> >>>  	 * PIO/MW_DMA cycle timing.
> >>>  	 */
> >>>  
> >>> -	if (adev->id[ATA_ID_FIELD_VALID] & 2) {	/* EIDE drive */
> >>> +	if (id[ATA_ID_FIELD_VALID] & 2) {	/* EIDE drive */
> >>>  		memset(&p, 0, sizeof(p));
> >>> +
> >>>  		if (speed >= XFER_PIO_0 && speed <= XFER_SW_DMA_0) {
> >>>   
> >>>       
> >>    BTW, shouldn't this actually be 'speed < XFER_SW_DMA_0'?
> >>     
> >
> > Good catch, I'll fix the patch later (would you be willing to fix
> > ide-timings.c side of things?).
> >   
> 
>    I don't see what to fix there?..

Ah, sorry, ide-timings.c change is also not upstream yet..
--
Bartlomiej Zolnierkiewicz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/