Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753123Ab0ARTwm (ORCPT ); Mon, 18 Jan 2010 14:52:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751638Ab0ARTwm (ORCPT ); Mon, 18 Jan 2010 14:52:42 -0500 Received: from mail.vyatta.com ([76.74.103.46]:45651 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401Ab0ARTwl (ORCPT ); Mon, 18 Jan 2010 14:52:41 -0500 Date: Mon, 18 Jan 2010 11:52:24 -0800 From: Stephen Hemminger To: Tino Keitel Cc: Mike McCormack , "Rafael J. Wysocki" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Regression: Wake on LAN doesn't work in sky2 with 2.6.33-rc4-git2 Message-ID: <20100118115224.1abde88b@nehalam> In-Reply-To: <20100118185245.GA3750@mac.home> References: <20100115091053.GA5477@mac.home> <201001152323.37718.rjw@sisk.pl> <20100117231932.GA5504@mac.home> <201001180136.45823.rjw@sisk.pl> <20100118083757.GA2619@mac.home> <4B544D2C.8040400@ring3k.org> <20100118185245.GA3750@mac.home> Organization: Vyatta X-Mailer: Claws Mail 3.7.2 (GTK+ 2.18.3; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 813 Lines: 23 Does it work better if config bit is set here? --- drivers/net/sky2.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) --- a/drivers/net/sky2.c 2010-01-18 11:45:54.444753324 -0800 +++ b/drivers/net/sky2.c 2010-01-18 11:49:18.475018945 -0800 @@ -283,6 +283,9 @@ static void sky2_power_aux(struct sky2_h /* turn off "driver loaded LED" */ sky2_write16(hw, B0_CTST, Y2_LED_STAT_OFF); + + /* disable writes to PCI config again */ + sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_OFF); } static void sky2_gmac_reset(struct sky2_hw *hw, unsigned port) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/