Subject: Re: [PATCH] video/matrox: Checkpatch cleanups for matroxfb_crtc2.c
From: Joe Perches <joe@perches.com>
To: Peter =?ISO-8859-1?Q?H=FCwe?= <PeterHuewe@gmx.de>
Cc: Petr Vandrovec <vandrove@vc.cvut.cz>,
       Andrew Morton <akpm@linux-foundation.org>,
       Jean Delvare <khali@linux-fr.org>, Krzysztof Helt <krzysztof.h1@wp.pl>,
       linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
       kernel-janitors@vger.kernel.org
In-Reply-To: <201001182027.29805.PeterHuewe@gmx.de>
References: <201001181934.49519.PeterHuewe@gmx.de>
	 <1263842269.26846.122.camel@Joe-Laptop.home>
	 <201001182027.29805.PeterHuewe@gmx.de>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 18 Jan 2010 11:59:30 -0800
Message-ID: <1263844770.26846.134.camel@Joe-Laptop.home>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 651
Lines: 19

On Mon, 2010-01-18 at 20:27 +0100, Peter Hüwe wrote:
> the reason behind this change was that spaces and tabs were mixed for 
> indention. 

Checkpatch isn't gospel and isn't always right.

There should be room for taste preference here
and I think whatever Petr V's is should prevail.

> How about this indention? Would this be better?

Well, I don't think so, but others will have different opinions.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/