Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755710Ab0ARVYX (ORCPT ); Mon, 18 Jan 2010 16:24:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754896Ab0ARVYW (ORCPT ); Mon, 18 Jan 2010 16:24:22 -0500 Received: from www.tglx.de ([62.245.132.106]:57341 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754859Ab0ARVYW (ORCPT ); Mon, 18 Jan 2010 16:24:22 -0500 Date: Mon, 18 Jan 2010 22:24:12 +0100 (CET) From: Thomas Gleixner To: Julia Lawall cc: Andreas Mohr , linux-kernel@vger.kernel.org, Greg KH Subject: Re: mcs7830 usb net: "scheduling while atomic" danger? In-Reply-To: Message-ID: References: <20100118184942.GA10171@rhlx01.hs-esslingen.de> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 869 Lines: 27 Julia, On Mon, 18 Jan 2010, Julia Lawall wrote: > On Mon, 18 Jan 2010, Andreas Mohr wrote: > > The semantic match shown below finds 55 matches. All but two involve > mutex_lock. Those are in the file As I said before the mutex_lock()/msleep() ones are fine. > /var/linuxes/linux-next/drivers/usb/host/ehci-hub.c > in the functions ehci_bus_suspend and ehci_hub_control. The msleep in ehci_hub_control() which happens with ehci->lock held and irqs disabled is definitely buggy. I can't see anything wrong wth the msleep in ehci_bus_suspend() as it is _before_ the spin_lock_irq(&ehci->lock) region. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/