Date: Mon, 18 Jan 2010 22:24:00 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Mark Allyn <mark.a.allyn@intel.com>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com, alan@linux.intel.com,
       charles.f.johnson@intel.com, Mark Allyn <mark.a.allyn@intel.com>
Subject: Re: [PATCH] Add Linux Driver for Intel Langwell Watchdog
Message-ID: <20100118222400.2b8fa0c2@lxorguk.ukuu.org.uk>
In-Reply-To: <1263849859-23265-1-git-send-email-mark.a.allyn@intel.com>
References: <1263849859-23265-1-git-send-email-mark.a.allyn@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 986
Lines: 33

> +	/* send the threshold and soft_threshold via IPC to the Lincroft */
> +	reg_data.payload1 = watchdog_device.soft_threshold;
> +	reg_data.payload2 = watchdog_device.threshold;
> +	ipc_set_watchdog(&reg_data);

That still doesn't seem to be merged upstream - someone needs poking to
at least get an IPC driver into staging.


> + * /dev/watchdog handling
> + */
> +static int langwell_open(struct inode *inode, struct file *file)
> +{
> +	/* Miscdevice structure pointer already saved in private_data */
> +
> +	struct watchdog_reg_data reg_data;
> +
> +	if (!capable(CAP_SYS_ADMIN))
> +		return -EPERM;

File permissions will deal with that bit

> +
> +	if (test_and_set_bit(0, &watchdog_device.driver_open))
> +		return -ENOTTY;

EBUSY

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/