Date: Mon, 18 Jan 2010 14:43:40 -0800
From: Stephen Hemminger <shemminger@vyatta.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Tino Keitel <tino.keitel@tikei.de>, netdev@vger.kernel.org,
       linux-kernel@vger.kernel.org
Subject: Re: Regression: Wake on LAN doesn't work in sky2 with
 2.6.33-rc4-git2
Message-ID: <20100118144340.100c9544@nehalam>
In-Reply-To: <201001182234.55113.rjw@sisk.pl>
References: <20100115091053.GA5477@mac.home>
	<201001180136.45823.rjw@sisk.pl>
	<20100118083757.GA2619@mac.home>
	<201001182234.55113.rjw@sisk.pl>
Organization: Vyatta
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1245
Lines: 37

On Mon, 18 Jan 2010 22:34:55 +0100
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:

> On Monday 18 January 2010, Tino Keitel wrote:
> > Hi,
> > 
> > reverting this commit fixes WoL for me:
> > 
> > commit 166a0fd4c788ec7f10ca8194ec6d526afa12db75
> > Author: stephen hemminger <shemminger@vyatta.com>
> > Date:   Mon Dec 14 08:50:12 2009 +0000
> > 
> >     sky2: leave PCI config space writeable
> >     
> >     Since power management is done by PCI subsystem as well as driver,
> >     don't toggle the bit that disables PCI register writes.
> >     
> >     Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> >     Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
> >     Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> Hmm, this is kind of interesting.
> 
> Perhaps we clear the WoL setting somewhere we shouldn't, but the
> "disable PCI register writes" bit prevents this from actually happening?
> 
> Rafael

How about getting a register dump of pci config space with
good/bad version?

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/