Date: Tue, 19 Jan 2010 07:25:55 +0100 (CET)
From: Julia Lawall <julia@diku.dk>
To: "Du, Alek" <alek.du@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Andreas Mohr <andi@lisas.de>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
       Greg KH <greg@kroah.com>, "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
       Alan Stern <stern@rowland.harvard.edu>
Subject: RE: mcs7830 usb net: "scheduling while atomic" danger?
In-Reply-To: <ED3036A092A28F4C91B0B4360DD128EA35987814@shzsmsx502.ccr.corp.intel.com>
Message-ID: <Pine.LNX.4.64.1001190725050.17802@ask.diku.dk>
References: <20100118184942.GA10171@rhlx01.hs-esslingen.de>
 <Pine.LNX.4.64.1001182206190.30446@ask.diku.dk> <201001182223.49764.arnd@arndb.de>
 <ED3036A092A28F4C91B0B4360DD128EA35987814@shzsmsx502.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1805
Lines: 50

So you will fix /var/linuxes/linux-next/drivers/usb/host/ehci-hub.c?

I think it is a bit out of my expertise...

julia


On Tue, 19 Jan 2010, Du, Alek wrote:

> I confirm that thing is bad, I need to prepare another patch to fix that.
> 
> Thanks,
> Alek
> >-----Original Message-----
> >From: Arnd Bergmann [mailto:arnd@arndb.de]
> >Sent: Tuesday, January 19, 2010 5:24 AM
> >To: Julia Lawall
> >Cc: Andreas Mohr; linux-kernel@vger.kernel.org; Greg KH; Du, Alek; Pan, Jacob
> >jun; Alan Stern
> >Subject: Re: mcs7830 usb net: "scheduling while atomic" danger?
> >
> >On Monday 18 January 2010, Julia Lawall wrote:
> >> On Mon, 18 Jan 2010, Andreas Mohr wrote:
> >> >
> >> > Forgive me, but doesn't that mutex_lock()/msleep() (ab)use mean
> >> > risking a "scheduling while atomic"?
> >> > (such as discussed in e.g.
> >> > http://search.luky.org/linux-kernel.2004/msg92817.html )
> >> >
> >> >
> >> > And, if that is the case, shouldn't all such cases simply be killed for
> >> > good via a capable semantic patch?
> >>
> >> The semantic match shown below finds 55 matches.  All but two involve
> >> mutex_lock.  Those are in the file
> >> /var/linuxes/linux-next/drivers/usb/host/ehci-hub.c
> >> in the functions ehci_bus_suspend and ehci_hub_control.
> >
> >That code looks indeed broken as was added las July as part of 331ac6b288d9
> >"USB: EHCI: Add Intel Moorestown EHCI controller HOSTPCx extensions and
> >support phy low power mode". The reason that this hasn't triggered is
> >probably the lack of Moorestown machines in the field.
> >
> >	Arnd
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/