Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754608Ab0ASHSB (ORCPT ); Tue, 19 Jan 2010 02:18:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754299Ab0ASHSA (ORCPT ); Tue, 19 Jan 2010 02:18:00 -0500 Received: from smtp1.entryit.no ([212.4.42.179]:55854 "EHLO smtp1.entryit.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752994Ab0ASHR7 convert rfc822-to-8bit (ORCPT ); Tue, 19 Jan 2010 02:17:59 -0500 From: Eirik Aanonsen To: Greg KH CC: "kernel@avr32linux.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Tue, 19 Jan 2010 08:16:26 +0100 Subject: RE: [PATCH 1/1] atmel uaba : Adding invert vbus_pin Thread-Topic: [PATCH 1/1] atmel uaba : Adding invert vbus_pin Thread-Index: AcqYwvehyrGTDLrkR0Cn961tzUBJowAE9MAg Message-ID: References: <20100115185457.GG12146@kroah.com> <20100119044912.GB10262@kroah.com> In-Reply-To: <20100119044912.GB10262@kroah.com> Accept-Language: nb-NO Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: nb-NO Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3395 Lines: 106 ... > > > Please always run your patches through 'scripts/checkpatch.pl' > before > > > sending them so that you don't accidentally add coding style > errors. > > > > > > thanks, > > > > > > greg k-h > > > > Yes I'm sorry I got that feedback from several others as well. > > > > That is why I resubmitted the patch on 05.Jan. But under the same > name, and since then I have not received any feedback on that patch. > > ... > > I don't see it in my queue, care to resend? > > thanks, > > greg k-h Adding it here: --- Thanks to Greg KH [greg@koah.com], Ben Nizette [bn@niasdigital.com] and Sergei Shtylyov [sshtylyov@ru.mvista.com] for good feedback Adding vbus_pin_inverted so that the usb detect pin can be active high or low. This because depending on HW implementation it is better to have active low. Also replaced the pio_get_value(udc->vbus_pin); with a call to vbus_is_present(udc); This change allows avr32 designes with vbus pin inverted to save 0,15watt when disconnected from a host. Signed-off-by: Eirik Aanonsen --- drivers/usb/gadget/atmel_usba_udc.c | 6 +++--- drivers/usb/gadget/atmel_usba_udc.h | 1 + include/linux/usb/atmel_usba_udc.h | 1 + 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c index 4e970cf..e1282fc 100644 --- a/drivers/usb/gadget/atmel_usba_udc.c +++ b/drivers/usb/gadget/atmel_usba_udc.c @@ -320,8 +320,7 @@ static inline void usba_cleanup_debugfs(struct usba_udc *udc) static int vbus_is_present(struct usba_udc *udc) { if (gpio_is_valid(udc->vbus_pin)) - return gpio_get_value(udc->vbus_pin); - + return gpio_get_value(udc->vbus_pin) ^ udc->vbus_pin_inverted; /* No Vbus detection: Assume always present */ return 1; } @@ -1763,7 +1762,7 @@ static irqreturn_t usba_vbus_irq(int irq, void *devid) if (!udc->driver) goto out; - vbus = gpio_get_value(udc->vbus_pin); + vbus = vbus_is_present(udc); if (vbus != udc->vbus_prev) { if (vbus) { toggle_bias(1); @@ -2000,6 +1999,7 @@ static int __init usba_udc_probe(struct platform_device *pdev) if (gpio_is_valid(pdata->vbus_pin)) { if (!gpio_request(pdata->vbus_pin, "atmel_usba_udc")) { udc->vbus_pin = pdata->vbus_pin; + udc->vbus_pin_inverted = pdata->vbus_pin_inverted; ret = request_irq(gpio_to_irq(udc->vbus_pin), usba_vbus_irq, 0, diff --git a/drivers/usb/gadget/atmel_usba_udc.h b/drivers/usb/gadget/atmel_usba_udc.h index f7baea3..88a2e07 100644 --- a/drivers/usb/gadget/atmel_usba_udc.h +++ b/drivers/usb/gadget/atmel_usba_udc.h @@ -323,6 +323,7 @@ struct usba_udc { struct platform_device *pdev; int irq; int vbus_pin; + int vbus_pin_inverted; struct clk *pclk; struct clk *hclk; diff --git a/include/linux/usb/atmel_usba_udc.h b/include/linux/usb/atmel_usba_udc.h index 6311fa2..643c4c5 100644 --- a/include/linux/usb/atmel_usba_udc.h +++ b/include/linux/usb/atmel_usba_udc.h @@ -15,6 +15,7 @@ struct usba_ep_data { struct usba_platform_data { int vbus_pin; + unsigned char vbus_pin_inverted; int num_ep; struct usba_ep_data ep[0]; }; -- 1.5.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/