Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753957Ab0ASN1c (ORCPT ); Tue, 19 Jan 2010 08:27:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750780Ab0ASN1a (ORCPT ); Tue, 19 Jan 2010 08:27:30 -0500 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:41846 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750733Ab0ASN11 (ORCPT ); Tue, 19 Jan 2010 08:27:27 -0500 Date: Tue, 19 Jan 2010 13:29:34 +0000 From: Alan Cox To: Oliver Neukum Cc: Matthew Garrett , dvomlehn@cisco.com, gregkh@suse.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [REGRESSION] "USB: use kfifo to buffer usb-generic serial writes" causes gobi_loader to hang Message-ID: <20100119132934.0c1688f7@lxorguk.ukuu.org.uk> In-Reply-To: <201001191420.29652.oliver@neukum.org> References: <20100117025535.GB7045@srcf.ucam.org> <201001181825.39823.oliver@neukum.org> <20100118201416.GA26511@srcf.ucam.org> <201001191420.29652.oliver@neukum.org> X-Mailer: Claws Mail 3.7.3 (GTK+ 2.18.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 870 Lines: 23 On Tue, 19 Jan 2010 14:20:29 +0100 Oliver Neukum wrote: > Am Montag, 18. Januar 2010 21:14:16 schrieb Matthew Garrett: > > > drivers/usb/serial/generic.c: usb_serial_generic_write - port 0, 1565 > > bytes > > drivers/usb/serial/generic.c: usb_serial_generic_write - put 0 bytes > > into fifo > > drivers/usb/serial/generic.c: usb_serial_generic_read_bulk_callback - > > port 0 > > If the FIFO is full we can do nothing. Please try the attached patch. If the FIFO is full how are we getting called - we should have throttled earlier if there is any flow control (including 'look no URBs' cases) ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/