Date: Tue, 19 Jan 2010 12:51:08 -0200
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Hagen Paul Pfeifer <hagen@jauu.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] thinkpad-acpi: fix link error to include sound arch
Message-ID: <20100119145108.GD2668@khazad-dum.debian.net>
References: <1263820516-6924-1-git-send-email-hagen@jauu.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1263820516-6924-1-git-send-email-hagen@jauu.net>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1063
Lines: 26

On Mon, 18 Jan 2010, Hagen Paul Pfeifer wrote:
> Thinkpad ACPI depends on sound for resume/suspend/shutdown
> events. This fix corrects the Kconfig dependency between

Does it?  I'd rather fix the real problem, it shouldn't depend on sound for
resume/suspend/shutdown.  If it does, the fix is to break the dependency.

> in-kernel build and module build. The preprocessor
> directive #ifdef CONFIG_THINKPAD_ACPI_ALSA_SUPPORT
> isn't sufficient to handle this build dependency.

NAK.

Can you describe the problem in more detail?  That will save me precious
time, as I am rather overworked right now...

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/