Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754661Ab0ASRjQ (ORCPT ); Tue, 19 Jan 2010 12:39:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752890Ab0ASRjP (ORCPT ); Tue, 19 Jan 2010 12:39:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60650 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751458Ab0ASRjN (ORCPT ); Tue, 19 Jan 2010 12:39:13 -0500 Subject: Re: [PATCH] kconfig: dont hardcode path to lsmod From: Steven Rostedt To: Mike Frysinger Cc: =?ISO-8859-1?Q?Am=E9rico?= Wang , linux-kbuild@vger.kernel.org, Andrew Morton , linux-kernel@vger.kernel.org In-Reply-To: <8bd0f97a1001190923p6104acb4if5ec7225d549b713@mail.gmail.com> References: <1263883920-17289-1-git-send-email-vapier@gentoo.org> <20100119142545.GB3473@hack> <8bd0f97a1001190923p6104acb4if5ec7225d549b713@mail.gmail.com> Content-Type: text/plain; charset="UTF-8" Organization: Red Hat Date: Tue, 19 Jan 2010 12:38:28 -0500 Message-Id: <1263922708.2737.139.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1121 Lines: 28 On Tue, 2010-01-19 at 12:23 -0500, Mike Frysinger wrote: > On Tue, Jan 19, 2010 at 09:25, Américo Wang wrote: > > On Tue, Jan 19, 2010 at 01:52:00AM -0500, Mike Frysinger wrote: > >>The lsmod utility has always been installed into /bin with the newer > >>module-init-tools package, so let lsmod be found via PATH instead of > >>hardcoding the old modutils /sbin path. > >> > > > > Some distro doesn't set /sbin to PATH, so for me a better solution > > would be making PATH contain /sbin, and then use "lsmod". > > read my changelog -- module-init-tools has always installed into /bin. > so what your distro does with /sbin doesnt matter. I still have boxes where lsmod is in /sbin, but that's beside the point. The patch I made checked for lsmod in /sbin /bin /usr/bin /usr/sbin /usr/local/bin and /usr/local/sbin. I could also make it do "lsmod" after that. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/