DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type:content-transfer-encoding;
        b=bqKfLOgJzh/oAX9uvG7ZSSMBKVuOe42ol7v5Ev24wKdzxvmNxaHuS10XE4C3idf+dE
         sqety+mfYMoREJpNLjhqdcIVrUbhXc6KB99jTjG0595gB4+Kwy3AE+jDhMTKB6VTHJoK
         wLgHPB1o84J/nQXPh+yJMF8txa7Q+cCYRLYcY=
MIME-Version: 1.0
In-Reply-To: <1263937351.18117.69.camel@Joe-Laptop.home>
References: <20100119211759.GE3804@infomag.iguana.be> <1263937351.18117.69.camel@Joe-Laptop.home>
From: Mike Frysinger <vapier.adi@gmail.com>
Date: Tue, 19 Jan 2010 16:52:21 -0500
Message-ID: <8bd0f97a1001191352n4968bebep2342912c571595fa@mail.gmail.com>
Subject: Re: [RFC] [PATCH] watchdog_info separation and constify
To: Joe Perches <joe@perches.com>
Cc: Wim Van Sebroeck <wim@iguana.be>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
       Andrew Morton <akpm@linux-foundation.org>,
       Florian Fainelli <florian@openwrt.org>,
       Russell King <rmk+kernel@arm.linux.org.uk>,
       Mark Brown <broonie@opensource.wolfsonmicro.com>,
       LKML <linux-kernel@vger.kernel.org>, linuxppc-dev@ozlabs.org,
       uclinux-dist-devel@blackfin.uclinux.org, linux-omap@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 797
Lines: 20

On Tue, Jan 19, 2010 at 16:42, Joe Perches wrote:
> On Tue, 2010-01-19 at 22:17 +0100, Wim Van Sebroeck wrote:
>> -static struct watchdog_info at32_wdt_info = {
>> +static const struct watchdog_info at32_wdt_info = {
>
> It'd be good to use a consistent structure name:
>
> static const struct watchdog_info ident = {
>        etc...
> }

i'd agree (obviously i'm partial to the "xxx_wdt_info" form), but i'd
worry about this after the watchdog implementations are finally
unified ... might be less code needing standardization at that point
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/