Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Subject: Re: [RFC] [PATCH] watchdog_info separation and constify
Date: Tue, 19 Jan 2010 16:53:26 -0500
Message-ID: <BD79186B4FD85F4B8E60E381CAEE1909020E8C70@mi8nycmail19.Mi8.com>
Thread-Topic: Re: [RFC] [PATCH] watchdog_info separation and constify
Thread-Index: AcqZUdRPLj9pwD0cRI61Fr5zRZCpCw==
From: "H Hartley Sweeten" <hartleys@visionengravers.com>
To: <wim@iguana.be>
Cc: <linux-kernel@vger.kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1454
Lines: 47

On Tue Jan 19, 2010, Wim Van Sebroeck wrote:
> Hi All,
> 
> please comment on following patch.
> 
> Kind regards,
> Wim.
> 
> commit 88d0b1a9c071d26e7b4831320067c84b04ea04a8
> Author: Wim Van Sebroeck <wim@xxxxxxxxx>
> Date: Sat Dec 26 18:55:22 2009 +0000
> 
> [WATCHDOG] watchdog_info separation and constify
> 
> make sure that the watchdog_info struct is seperated from the ioctl code.
> Also make the struct const where possible.
> 
> Signed-off-by: Wim Van Sebroeck <wim@xxxxxxxxx>

[snip]

> diff --git a/drivers/watchdog/ep93xx_wdt.c b/drivers/watchdog/ep93xx_wdt.c
> index cdd55e0..88ed54e 100644
> --- a/drivers/watchdog/ep93xx_wdt.c
> +++ b/drivers/watchdog/ep93xx_wdt.c
> @@ -131,7 +131,7 @@ ep93xx_wdt_write(struct file *file, const char __user *data, size_t len,
> return len;
> }
> 
> -static struct watchdog_info ident = {
> +static const struct watchdog_info ident = {
> .options = WDIOF_CARDRESET | WDIOF_MAGICCLOSE,
> .identity = "EP93xx Watchdog",
> };

Before:
$ size ep93xx_wdt.o
   text	   data	    bss	    dec	    hex	filename
   1613	     88	     40	   1741	    6cd	ep93xx_wdt.o

After:
$ size ep93xx_wdt.o
   text	   data	    bss	    dec	    hex	filename
   1653	     48	     40	   1741	    6cd	ep93xx_wdt.o

Tested-by: H Hartley Sweeten <hsweeten@visionengravers.com>
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?