Message-ID: <4B5634D9.2060303@emulex.com>
Date: Tue, 19 Jan 2010 17:40:25 -0500
From: James Smart <james.smart@emulex.com>
User-Agent: Thunderbird 2.0.0.23 (Windows/20090812)
MIME-Version: 1.0
To: Roel Kluin <roel.kluin@gmail.com>
CC: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
       Andrew Morton <akpm@linux-foundation.org>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lpfc: two branches the same in lpfc_decode_firmware_rev()
References: <4B5329AD.9010100@gmail.com>
In-Reply-To: <4B5329AD.9010100@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1151
Lines: 38

Acked-by:  James Smart <james.smart@emulex.com>

-- james s


Roel Kluin wrote:
> Regardless of the flag state, the branches execute the same code
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
>  drivers/scsi/lpfc/lpfc_ct.c |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
> index 0ebcd9b..bf7bf62 100644
> --- a/drivers/scsi/lpfc/lpfc_ct.c
> +++ b/drivers/scsi/lpfc/lpfc_ct.c
> @@ -1843,12 +1843,7 @@ lpfc_decode_firmware_rev(struct lpfc_hba *phba, char *fwrevision, int flag)
>  		c  = (rev & 0x0000ff00) >> 8;
>  		b4 = (rev & 0x000000ff);
>  
> -		if (flag)
> -			sprintf(fwrevision, "%d.%d%d%c%d ", b1,
> -				b2, b3, c, b4);
> -		else
> -			sprintf(fwrevision, "%d.%d%d%c%d ", b1,
> -				b2, b3, c, b4);
> +		sprintf(fwrevision, "%d.%d%d%c%d", b1, b2, b3, c, b4);
>  	}
>  	return;
>  }
>
>   
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/