Date: Wed, 20 Jan 2010 12:09:42 -0200
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>, Ingo Molnar <mingo@elte.hu>,
       Paul Mackerras <paulus@samba.org>,
       Frederic Weisbecker <fweisbec@gmail.com>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf tools: fix write_event()
Message-ID: <20100120140942.GP14636@ghostprotocols.net>
References: <4B570657.5090105@cn.fujitsu.com>
 <1263994901.4283.1060.camel@laptop>
 <1263995096.4283.1062.camel@laptop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1263995096.4283.1062.camel@laptop>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1098
Lines: 26

Em Wed, Jan 20, 2010 at 02:44:56PM +0100, Peter Zijlstra escreveu:
> On Wed, 2010-01-20 at 14:41 +0100, Peter Zijlstra wrote:
> > On Wed, 2010-01-20 at 21:34 +0800, Xiao Guangrong wrote:
> > > We parse the event while it's read from mmap buffer in
> > > write_event(), but sometimes the event will straddles the
> > > mmap boundary, we should handle this case
> > > 
> > > And if we record events(such as perf kmem/sched) for long
> > > times, Ctrl + C can't interrupt it just for this reason
> > 
> > Uhm, how why? it didn't used to know about events and just copied the
> > data.
> 
> looks like acme wrecked it in f5a2c3dc.. anyway the fix is wrong, record
> should not know or care about the actual events and simply write data
> out.

Oh well, I guess then we should do that after record finishes,
reprocessing all the data in the file.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/