Subject: Re: [PATCH] perf tools: fix write_event()
From: Peter Zijlstra <peterz@infradead.org>
To: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>, Ingo Molnar <mingo@elte.hu>,
       Paul Mackerras <paulus@samba.org>,
       Frederic Weisbecker <fweisbec@gmail.com>,
       LKML <linux-kernel@vger.kernel.org>
In-Reply-To: <1263996897.4283.1065.camel@laptop>
References: <4B570657.5090105@cn.fujitsu.com>
	 <1263994901.4283.1060.camel@laptop> <1263995096.4283.1062.camel@laptop>
	 <20100120140942.GP14636@ghostprotocols.net>
	 <1263996897.4283.1065.camel@laptop>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 20 Jan 2010 15:43:30 +0100
Message-ID: <1263998610.4283.1076.camel@laptop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 851
Lines: 22

On Wed, 2010-01-20 at 15:14 +0100, Peter Zijlstra wrote:

> > > > Uhm, how why? it didn't used to know about events and just copied the
> > > > data.
> > > 
> > > looks like acme wrecked it in f5a2c3dc.. anyway the fix is wrong, record
> > > should not know or care about the actual events and simply write data
> > > out.
> > 
> > Oh well, I guess then we should do that after record finishes,
> > reprocessing all the data in the file.
> 
> Why do we need it at all?

To clarify, we want to keep the record cycle as small/fast as possible
in order to minimize permutation of the system we're recording.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/