Date: Wed, 20 Jan 2010 17:09:50 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: mtosatti@redhat.com, Davide Libenzi <davidel@xmailserver.org>,
       kvm@vger.kernel.org,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] kvm: fix spurious interrupt with irqfd
Message-ID: <20100120150950.GD3434@redhat.com>
References: <20100113171222.GA19798@redhat.com> <4B5305CA.5070001@redhat.com> <20100119145202.GC28465@redhat.com> <4B570EDD.6000808@redhat.com> <20100120145822.GB3434@redhat.com> <4B571CAC.9000902@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B571CAC.9000902@redhat.com>
User-Agent: Mutt/1.5.19 (2009-01-05)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1023
Lines: 31

On Wed, Jan 20, 2010 at 05:09:32PM +0200, Avi Kivity wrote:
> On 01/20/2010 04:58 PM, Michael S. Tsirkin wrote:
>>
>>> I'm uncomfortable with pushing Davide's patch into stable and possibly
>>> causing regressions with unrelated applications.  Can't a guest live
>>> with a spurious interrupt?
>>>      
>> Well guests mask/unmask vector on each interrupt, so this will trigger
>> an irq storm I think.
>>
>>    
>>>   It's not like they're unknown.
>>>      
>> Depends on the device really.
>> In theory, if they trigger at an unfortunate time this could cause
>> crashes.
>>
>>    
>
> I'd like confirmation on both of these before I push things to stable.

I have observed the interrupt storm. We end up with interrupt being
disabled. Crash is a theoretical issue.

-- 
MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/