Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753732Ab0ATRTn (ORCPT ); Wed, 20 Jan 2010 12:19:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753688Ab0ATRTk (ORCPT ); Wed, 20 Jan 2010 12:19:40 -0500 Received: from ey-out-2122.google.com ([74.125.78.24]:10382 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753667Ab0ATRTi (ORCPT ); Wed, 20 Jan 2010 12:19:38 -0500 Subject: Re: [PATCH] powernow-k8: On load failure, remind the user to enable support in BIOS setup From: Marti Raudsepp To: Thomas Renninger Cc: cpufreq@vger.kernel.org, Dave Jones , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Mark Langsdorf , Rusty Russell , Andreas Herrmann , linux-kernel@vger.kernel.org In-Reply-To: <201001201656.51376.trenn@suse.de> References: <160211accaba09e778c6.1264001606@newn> <201001201656.51376.trenn@suse.de> Content-Type: text/plain; charset="UTF-8" Date: Wed, 20 Jan 2010 19:19:33 +0200 Message-ID: <1264007973.18960.45.camel@newn> Mime-Version: 1.0 X-Mailer: Evolution 2.28.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1677 Lines: 50 On Wed, 2010-01-20 at 16:56 +0100, Thomas Renninger wrote: > But most often this happens if people upgrade their CPU and do not > update their BIOS. > Or the vendor does not recognise the new CPU even if the BIOS got > updated. Maybe some of those people just didn't realize it was disabled in BIOS? If you tell users that it's a firmware bug then they'll probably just give up. > The itself message might be an enhancment, IMO it's not worth a patch. Why do you think so? I spent an hour on hunting down the BIOS upgrade, only to find that it didn't improve anything. It was a day later that I realized that it might be a BIOS option; and the option was literally the _last_ option in the whole BIOS setup. :) This message would have saved the day. > But do not revert the FW_BUG part! Sure, you have a point here. How about this patch? --- powernow-k8: On load failure, tell user to update BIOS and enable in BIOS setup Signed-off-by: Marti Raudsepp diff --git a/arch/x86/kernel/cpu/cpufreq/powernow-k8.c b/arch/x86/kernel/cpu/cpufreq/powernow-k8.c --- a/arch/x86/kernel/cpu/cpufreq/powernow-k8.c +++ b/arch/x86/kernel/cpu/cpufreq/powernow-k8.c @@ -800,6 +800,8 @@ * www.amd.com */ printk(KERN_ERR FW_BUG PFX "No PSB or ACPI _PSS objects\n"); + printk(KERN_ERR PFX "Make sure that your BIOS is up to date" + " and Cool'N'Quiet support is enabled in BIOS setup\n"); return -ENODEV; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/