From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Greg KH <greg@kroah.com>
Subject: Re: [RFC][PATCH] PM / Runtime: Add sysfs switch for disabling device run-time PM
Date: Wed, 20 Jan 2010 21:55:36 +0100
User-Agent: KMail/1.12.3 (Linux/2.6.33-rc4-rjw; KDE/4.3.3; x86_64; ; )
Cc: pm list <linux-pm@lists.linux-foundation.org>,
       LKML <linux-kernel@vger.kernel.org>,
       Jesse Barnes <jbarnes@virtuousgeek.org>,
       Matthew Garrett <mjg59@srcf.ucam.org>,
       Alan Stern <stern@rowland.harvard.edu>
References: <201001180129.55219.rjw@sisk.pl> <20100120025147.GA20979@kroah.com>
In-Reply-To: <20100120025147.GA20979@kroah.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201001202155.37062.rjw@sisk.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1487
Lines: 34

On Wednesday 20 January 2010, Greg KH wrote:
> On Mon, Jan 18, 2010 at 01:29:55AM +0100, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> > Subject: PM / Runtime: Add sysfs switch for disabling device run-time PM
> > 
> > Add new device sysfs attribute, power/runtime, allowing the user
> > space to block the run-time power management of the device.  If this
> > attribute is set to "disabled", the driver of the device won't be
> > able to enable run-time power management for it (without breaking the
> > rules).
> > 
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > ---
> >  drivers/base/power/power.h   |    4 +
> >  drivers/base/power/runtime.c |  107 +++++++++++++++++++++++++++++++++----------
> >  drivers/base/power/sysfs.c   |   46 ++++++++++++++++++
> >  include/linux/pm.h           |    1 
> >  include/linux/pm_runtime.h   |   11 +---
> >  5 files changed, 139 insertions(+), 30 deletions(-)
> 
> You forgot to also add an entry into Documentation/ABI/ for when you
> add/change a sysfs file :)

There's no description for /sys/devices/.../power/wakeup in there too and
that one has been present for quite some time already.

I'd prefer adding them both in a separate patch if you don't mind.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/