Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754373Ab0ATVSk (ORCPT ); Wed, 20 Jan 2010 16:18:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754015Ab0ATVSi (ORCPT ); Wed, 20 Jan 2010 16:18:38 -0500 Received: from smtp-out003.kontent.com ([81.88.40.217]:50488 "EHLO smtp-out003.kontent.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753774Ab0ATVSh (ORCPT ); Wed, 20 Jan 2010 16:18:37 -0500 From: Oliver Neukum To: "Rick L. Vinyard Jr." Subject: Re: [PATCH] hid: Logitech G13 driver 0.0.4 Date: Wed, 20 Jan 2010 22:19:12 +0100 User-Agent: KMail/1.12.2 (Linux/2.6.33-rc3-0.1-default; KDE/4.3.1; x86_64; ; ) Cc: linux-kernel@vger.kernel.org, felipe.balbi@nokia.com, pavel@ucw.cz, jayakumar.lkml@gmail.com, linux-fbdev@vger.kernel.org, krzysztof.h1@wp.pl, akpm@linux-foundation.org, linux-usb@vger.kernel.org, linux-input@vger.kernel.org, jkosina@suse.cz, dmitry.torokhov@gmail.com References: <201001202047.o0KKlMTr014003@mustang.cs.nmsu.edu> In-Reply-To: <201001202047.o0KKlMTr014003@mustang.cs.nmsu.edu> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201001202219.12058.oliver@neukum.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 594 Lines: 20 Am Mittwoch, 20. Januar 2010 21:47:22 schrieb Rick L. Vinyard Jr.: > + if (copy_from_user(dst, buf, count)) > + err = -EFAULT; > + > + if (!err) > + *ppos += count; > + > + g13_fb_update(par); > + > + return (err) ? err : count; Do you really want to go on if you get -EFAULT? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/