Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754779Ab0ATVjN (ORCPT ); Wed, 20 Jan 2010 16:39:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754150Ab0ATVjM (ORCPT ); Wed, 20 Jan 2010 16:39:12 -0500 Received: from borg.medozas.de ([188.40.89.202]:35592 "EHLO borg.medozas.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753733Ab0ATVjL (ORCPT ); Wed, 20 Jan 2010 16:39:11 -0500 Date: Wed, 20 Jan 2010 22:39:09 +0100 (CET) From: Jan Engelhardt To: Simon Arlott cc: Patrick McHardy , William Allen Simpson , netdev , Linux Kernel Mailing List , netfilter-devel@vger.kernel.org Subject: Re: [PATCH] xt_TCPMSS: SYN packets are allowed to contain data In-Reply-To: <4B5773C2.2010000@simon.arlott.org.uk> Message-ID: References: <4B54CDE5.3070100@simon.arlott.org.uk> <4B5578A5.50705@gmail.com> <4B55D372.4020807@gmail.com> <710ab0ca79305c82013982d43250b0a1fd45824d@8b5064a13e22126c1b9329f0dc35b8915774b7c3.invalid> <4B5773C2.2010000@simon.arlott.org.uk> User-Agent: Alpine 2.01 (LSU 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 751 Lines: 20 On Wednesday 2010-01-20 22:21, Simon Arlott wrote: >The TCPMSS target is dropping SYN packets where: > 1) There is data, or > 2) The data offset makes the TCP header larger than > the packet. > >Both of these result in an error level printk. > >This change fixes the drop of SYN packets with data >(because the MSS option can safely be modified) and >passes packets with no MSS option instead of adding >one (which is not valid). Can you explain why the automatic addition of a MSS option is removed? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/