Return-Path: <linux-kernel-owner+w=401wt.eu-S1755246Ab0AUKtP@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755246Ab0AUKtP (ORCPT <rfc822;w@1wt.eu>);
	Thu, 21 Jan 2010 05:49:15 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754912Ab0AUKtO
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 21 Jan 2010 05:49:14 -0500
Received: from mgw2.diku.dk ([130.225.96.92]:60533 "EHLO mgw2.diku.dk"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753769Ab0AUKtN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 21 Jan 2010 05:49:13 -0500
Date: Thu, 21 Jan 2010 11:49:10 +0100 (CET)
From: Julia Lawall <julia@diku.dk>
To: David Miller <davem@davemloft.net>
Cc: vladislav.yasevich@hp.com, sri@us.ibm.com, linux-sctp@vger.kernel.org,
       netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
       kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 4/9] net/sctp: Eliminate useless code
In-Reply-To: <20100121.024337.57448535.davem@davemloft.net>
Message-ID: <Pine.LNX.4.64.1001211148310.13529@ask.diku.dk>
References: <4B574702.4040602@hp.com> <20100120.150343.236848237.davem@davemloft.net>
 <Pine.LNX.4.64.1001211121500.13529@ask.diku.dk> <20100121.024337.57448535.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1930
Lines: 66

On Thu, 21 Jan 2010, David Miller wrote:

> From: Julia Lawall <julia@diku.dk>
> Date: Thu, 21 Jan 2010 11:22:38 +0100 (CET)
> 
> > On Wed, 20 Jan 2010, David Miller wrote:
> > 
> >> From: Vlad Yasevich <vladislav.yasevich@hp.com>
> >> Date: Wed, 20 Jan 2010 13:10:10 -0500
> >> 
> >> > 
> >> > 
> >> > Julia Lawall wrote:
> >> >> From: Julia Lawall <julia@diku.dk>
> >> >> 
> >> >> The variable newinet is initialized twice to the same (side effect-free)
> >> >> expression.  Drop one initialization.
> >> >> 
> >> >> A simplified version of the semantic match that finds this problem is:
> >> >> (http://coccinelle.lip6.fr/)
> >> >> 
> >> >> // <smpl>
> >> >> @forall@
> >> >> idexpression *x;
> >> >> identifier f!=ERR_PTR;
> >> >> @@
> >> >> 
> >> >> x = f(...)
> >> >> ... when != x
> >> >> (
> >> >> x = f(...,<+...x...+>,...)
> >> >> |
> >> >> * x = f(...)
> >> >> )
> >> >> // </smpl>
> >> >> 
> >> >> Signed-off-by: Julia Lawall <julia@diku.dk>
> >> > 
> >> > Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com>
> >> 
> >> Julia,  just like patch #3 this one had the missing final
> >> line of the patch corrupting it, so you'll need to resubmit.
> > 
> > I have generated and sent it again, but this time I don't see the problem.  
> > If there is still a problem, perhaps you could send me back the patch you 
> > received?
> 
> You dropped Vlad' ACK in your re-submission.
> 
> I'll fix it up this time, but please accumulate ACK's when
> resubmitting patches merely for the purpose of fixing some
> technical submission problem.
> 
> Thanks.

OK, I will keep that in mind.

Is the new one better than the old one?  Because in my local copies, they 
are the same...

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/