Subject: Re: perf top: losing events?
From: Mike Galbraith <efault@gmx.de>
To: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
       LKML <linux-kernel@vger.kernel.org>
In-Reply-To: <20100121144902.GA1244@ghostprotocols.net>
References: <1264052528.26323.13.camel@marge.simson.net>
	 <20100121122224.GA21083@ghostprotocols.net>
	 <1264084112.5933.6.camel@marge.simson.net>
	 <20100121144902.GA1244@ghostprotocols.net>
Content-Type: text/plain
Date: Thu, 21 Jan 2010 15:56:12 +0100
Message-Id: <1264085772.5979.3.camel@marge.simson.net>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1327
Lines: 39

On Thu, 2010-01-21 at 12:49 -0200, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jan 21, 2010 at 03:28:32PM +0100, Mike Galbraith escreveu:
> > On Thu, 2010-01-21 at 10:22 -0200, Arnaldo Carvalho de Melo wrote:
> > 
> > > Can you check if this one helps? 
> > 
> > Made interrupt count correct, but symbols aren't mapped after the task
> > forks it seems.  At least, in event__preprocess_sample(), after
> > thread__find_addr_location(), al->map is NULL a LOT.
> 
> Try this one on top of the previous one:
> 
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> index 8b04988..2227b84 100644
> --- a/tools/perf/builtin-top.c
> +++ b/tools/perf/builtin-top.c
> @@ -975,6 +975,10 @@ static int event__process(event_t *event, struct perf_session *session)
>  	case PERF_RECORD_MMAP:
>  		event__process_mmap(event, session);
>  		break;
> +	case PERF_RECORD_FORK:
> +	case PERF_RECORD_EXIT:
> +		event__process_task(event, session);
> +		break;
>  	default:
>  		break;
>  	}

Yup.  All better.

I figured that had to to be tied in from rummaging around earlier.

	-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/