Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Mon, 15 Apr 2002 04:52:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Mon, 15 Apr 2002 04:52:07 -0400 Received: from ns.virtualhost.dk ([195.184.98.160]:22282 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id ; Mon, 15 Apr 2002 04:52:06 -0400 Date: Mon, 15 Apr 2002 10:51:45 +0200 From: Jens Axboe To: Martin Dalecki Cc: Linus Torvalds , Kernel Mailing List Subject: Re: [PATCH] 2.5.8 IDE 34 Message-ID: <20020415085145.GF12608@suse.de> In-Reply-To: <3CBA8476.9070208@evision-ventures.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 15 2002, Martin Dalecki wrote: Two comments -- Could you please _not_ just rearrange comments or change style in ide-cd just for the sake cleaning, it's very annoying when one has patches that need to be adapted every time. And it serves zero purpose. Thanks. I changed the CONFIG_BLK_DEV_IDEPCI stuff to always include the pci_dev in the hwgroup, and just leave it at NULL if not defined. This cleans up some ifdefs, I think this is the better approach. I'll sync the latest tcq stuff with you later today, it gets the enabling right etc. And a last comment not directly related to this particular patch -- when you include something and change minor stuff along the way, please do it in two steps. One that includes a patch, and a second version that changes what you want to change. That makes merging _so_ much easier. Thanks. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/