Date: Thu, 21 Jan 2010 07:54:39 -0800 (PST)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Yinghai Lu <yinghai@kernel.org>
cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
       "H. Peter Anvin" <hpa@zytor.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       Jesse Barnes <jbarnes@virtuousgeek.org>,
       Christoph Lameter <cl@linux-foundation.org>,
       linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 05/36] x86/pci: enable pci root res read out for 32bit
 too
In-Reply-To: <1264055303-15123-6-git-send-email-yinghai@kernel.org>
Message-ID: <alpine.LFD.2.00.1001210750140.13231@localhost.localdomain>
References: <1264055303-15123-1-git-send-email-yinghai@kernel.org> <1264055303-15123-6-git-send-email-yinghai@kernel.org>
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 894
Lines: 26


On Wed, 20 Jan 2010, Yinghai Lu wrote:
>
>  			printk(KERN_DEBUG "bus: %02x index %x %s: [%llx, %llx]\n",
>  			       busnum, j,
>  			       (res->flags & IORESOURCE_IO)?"io port":"mmio",
> -			       res->start, res->end);
> +			       (u64)res->start, (u64)res->end);

When fixing these kinds of things, please just make it use '%pR' instead.

A simple

	printk(KERN_DEBUG "bus: %02x index %x %pR\n", busnum, j, res);

should do the right thing, printing the resource with nice human-readable 
flags. Including things like 64-bit/prefetching information for memory 
resources etc that the current manual resource printout doesn't do.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/