Message-ID: <4B58B2AC.5050906@kernel.org>
Date: Thu, 21 Jan 2010 12:01:48 -0800
From: Yinghai Lu <yinghai@kernel.org>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091130 SUSE/3.0.0-1.1.1 Thunderbird/3.0
MIME-Version: 1.0
To: Linus Torvalds <torvalds@linux-foundation.org>
CC: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
       "H. Peter Anvin" <hpa@zytor.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       Jesse Barnes <jbarnes@virtuousgeek.org>,
       Christoph Lameter <cl@linux-foundation.org>,
       linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 04/36] x86/pci: add cap_resource
References: <1264055303-15123-1-git-send-email-yinghai@kernel.org> <1264055303-15123-5-git-send-email-yinghai@kernel.org> <alpine.LFD.2.00.1001210745330.13231@localhost.localdomain>
In-Reply-To: <alpine.LFD.2.00.1001210745330.13231@localhost.localdomain>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1969
Lines: 69

On 01/21/2010 07:49 AM, Linus Torvalds wrote:
> 
> 
> On Wed, 20 Jan 2010, Yinghai Lu wrote:
>>
>> -v2: hpa said we should compare with (resource_size_t)~0
> 
> Hmm. Some of these look dubious.
> 
>> diff --git a/arch/x86/pci/bus_numa.c b/arch/x86/pci/bus_numa.c
>> index f939d60..b267919 100644
>> --- a/arch/x86/pci/bus_numa.c
>> +++ b/arch/x86/pci/bus_numa.c
>> @@ -60,6 +60,9 @@ void __devinit update_res(struct pci_root_info *info, size_t start,
>>  	if (start > end)
>>  		return;
>>  
>> +	if (start == (resource_size_t)~0)
>> +		return;
> 
> Here, 'start' isn't a resource_size_t. It's a regular size_t. And if 
> resource_size_t is u64, and size_t is u32, this test can never be true.
> 
> Maybe that is intentional, but if looks odd/wrong. Needs a comment if 
> right, needs fixing if wrong.

you are right, there are two patches about that already went into pci/linux-next

will ask Jesse to drop them from pci tree.

so could make them go via tip/x86

http://git.kernel.org/?p=linux/kernel/git/jbarnes/pci-2.6.git;a=commitdiff;h=f84fe8aef6e4b23ab58175a15dd12c197c993f81
http://git.kernel.org/?p=linux/kernel/git/jbarnes/pci-2.6.git;a=commitdiff;h=693f084f82a38fc1b01e3b05664a6fe014a3488a

or later may have merge problem.


> 
>> +static inline resource_size_t cap_resource(u64 val)
>> +{
>> +	if (val > (resource_size_t)~0)
>> +		return (resource_size_t)~0;
>> +	else
>> +		return val;
>> +}
>>  #endif
> 
> And this just looks odd. I'd suggest just doing
> 
> 	#define MAX_RESOURCE ((resource_size_t)~0)
> 
> 	static inline resource_size_t cap_resource(u64 val)
> 	{
> 		if (val > MAX_RESOURCE)
> 			val = MAX_RESOURCE;
> 		return val;
> 	}
> 
> instead, which looks a whole lot more natural. No?

OK

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/