Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755103Ab0AUUNX (ORCPT ); Thu, 21 Jan 2010 15:13:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753384Ab0AUUNW (ORCPT ); Thu, 21 Jan 2010 15:13:22 -0500 Received: from hera.kernel.org ([140.211.167.34]:59287 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752077Ab0AUUNV (ORCPT ); Thu, 21 Jan 2010 15:13:21 -0500 Message-ID: <4B58B515.2050809@kernel.org> Date: Thu, 21 Jan 2010 12:12:05 -0800 From: Yinghai Lu User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091130 SUSE/3.0.0-1.1.1 Thunderbird/3.0 MIME-Version: 1.0 To: Linus Torvalds CC: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , Jesse Barnes , Christoph Lameter , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 05/36] x86/pci: enable pci root res read out for 32bit too References: <1264055303-15123-1-git-send-email-yinghai@kernel.org> <1264055303-15123-6-git-send-email-yinghai@kernel.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 972 Lines: 29 On 01/21/2010 07:54 AM, Linus Torvalds wrote: > > > On Wed, 20 Jan 2010, Yinghai Lu wrote: >> >> printk(KERN_DEBUG "bus: %02x index %x %s: [%llx, %llx]\n", >> busnum, j, >> (res->flags & IORESOURCE_IO)?"io port":"mmio", >> - res->start, res->end); >> + (u64)res->start, (u64)res->end); > > When fixing these kinds of things, please just make it use '%pR' instead. > > A simple > > printk(KERN_DEBUG "bus: %02x index %x %pR\n", busnum, j, res); > > should do the right thing, printing the resource with nice human-readable > flags. Including things like 64-bit/prefetching information for memory > resources etc that the current manual resource printout doesn't do. ok. YH -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/