Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752191Ab0AVIgV (ORCPT ); Fri, 22 Jan 2010 03:36:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752027Ab0AVIgU (ORCPT ); Fri, 22 Jan 2010 03:36:20 -0500 Received: from one.firstfloor.org ([213.235.205.2]:38122 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751695Ab0AVIgT (ORCPT ); Fri, 22 Jan 2010 03:36:19 -0500 Date: Fri, 22 Jan 2010 09:36:16 +0100 From: Andi Kleen To: Valdis.Kletnieks@vt.edu Cc: Andi Kleen , linux-kernel@vger.kernel.org, x86@kernel.org, robert.richter@amd.com, oprofile-list@lists.sf.net Subject: Re: [PATCH] Add Xeon 7500 series support to oprofile Message-ID: <20100122083616.GA20592@one.firstfloor.org> References: <20100121222627.GA22897@basil.fritz.box> <28939.1264126458@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <28939.1264126458@localhost> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 555 Lines: 19 > > I'll bite - why a hex constant rather than the decimal values nearby? Why not? > > Also, should we do something about *cpu_type so it isn't confusing on a 7500 > reporting itself as a i7? No, that wouldn't be compatible to oprofile userland. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/