Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753248Ab0AVKsS (ORCPT ); Fri, 22 Jan 2010 05:48:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753004Ab0AVKsR (ORCPT ); Fri, 22 Jan 2010 05:48:17 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:35219 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752915Ab0AVKsP (ORCPT ); Fri, 22 Jan 2010 05:48:15 -0500 Subject: Re: [RFC] [PATCH 0/7] UBP, XOL and Uprobes [ Summary of Comments and actions to be taken ] From: Peter Zijlstra To: ananth@in.ibm.com Cc: Srikar Dronamraju , Ingo Molnar , utrace-devel , Frederic Weisbecker , Masami Hiramatsu , Maneesh Soni , Jim Keniston , Avi Kivity , Pekka Enberg , Mel Gorman , "Paul E. McKenney" , LKML In-Reply-To: <20100122072402.GA7440@in.ibm.com> References: <20100111122521.22050.3654.sendpatchset@srikar.in.ibm.com> <20100122070232.GA2975@linux.vnet.ibm.com> <20100122072402.GA7440@in.ibm.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 22 Jan 2010 11:47:37 +0100 Message-ID: <1264157257.4283.1529.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1494 Lines: 31 On Fri, 2010-01-22 at 12:54 +0530, Ananth N Mavinakayanahalli wrote: > On Fri, Jan 22, 2010 at 12:32:32PM +0530, Srikar Dronamraju wrote: > > Here is a summary of the Comments and actions that need to be taken for > > the current uprobes patchset. Please let me know if I missed or > > misunderstood any of your comments. > > > > 1. Uprobes depends on trap signal. > > Uprobes depends on trap signal rather than hooking to the global > > die notifier. It was suggested that we hook to the global die notifier. > > > > In the next version of patches, Uprobes will use the global die > > notifier and look at the per-task count of the probes in use to > > see if it has to be consumed. > > > > However this would reduce the ability of uprobe handlers to > > sleep. Since we are dealing with userspace, sleeping in handlers > > would have been a good feature. We are looking at ways to get > > around this limitation. > > We could set a TIF_ flag in the notifier to indicate a breakpoint hit > and process it in task context before the task heads into userspace. Make that optional, not everybody might want that. Either provide a simple trampoline or use a flag to indicate the callback be called from process context on registration. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/