Date: Fri, 22 Jan 2010 09:04:41 -0800
From: Stephen Hemminger <shemminger@vyatta.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andi Kleen <andi@firstfloor.org>, Joe Perches <joe@perches.com>,
       linux-kernel@vger.kernel.org, Marcin Slusarz <marcin.slusarz@gmail.com>,
       Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
       Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 00/24] drivers/block/floppy.c cleanups
Message-ID: <20100122090441.10716815@nehalam>
In-Reply-To: <20100122114653.4afd606d@lxorguk.ukuu.org.uk>
References: <cover.1264133863.git.joe@perches.com>
	<87fx5yh0va.fsf@basil.nowhere.org>
	<20100122114653.4afd606d@lxorguk.ukuu.org.uk>
Organization: Vyatta
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1014
Lines: 25

On Fri, 22 Jan 2010 11:46:53 +0000
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> > Philosophically I'm not sure it's that great an idea to make bad code
> > look better without actually fixing/rewriting it. It's like putting
> > lipstick on a pig.
> 
> Unpacking the mess and sorting out the whacky macros is more like
> removing all muck from the mechanism so you can see what needs to be done.
> 
> So I disagree - its a useful first step only

I had a reason in motivating this. For some cases, customers use floppy as
a configuration storage, and there were a number of strange errors
showing up occasionally in recent kernels. But the driver is such
an old crufty mess, it wasn't worth investigating further.

Making the code clearer gets rid of that excuse.

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/