Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752663Ab0AWUhI (ORCPT ); Sat, 23 Jan 2010 15:37:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752164Ab0AWUgQ (ORCPT ); Sat, 23 Jan 2010 15:36:16 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:50643 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751832Ab0AWUgM (ORCPT ); Sat, 23 Jan 2010 15:36:12 -0500 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Greg KH Cc: linux-kernel@vger.kernel.org, Eric Miao , Russell King , Paul Sokolovsky , Richard Purdie , Liam Girdwood , Andrew Morton Subject: [PATCH 06/29] move corgi-ssp's probe function to .devinit.text Date: Sat, 23 Jan 2010 21:35:14 +0100 Message-Id: <1264278937-19675-6-git-send-email-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 1.6.6 In-Reply-To: <1264189758-7197-1-git-send-email-u.kleine-koenig@pengutronix.de> References: <1264189758-7197-1-git-send-email-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1616 Lines: 42 A pointer to corgi_ssp_probe is passed to the core via platform_driver_register and so the function must not disappear when the .init sections are discarded. Otherwise (when having HOTPLUG=y) unbinding and binding a device to the driver via sysfs will result in an oops as does a device being registered late. An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver. Signed-off-by: Uwe Kleine-König Cc: Eric Miao Cc: Russell King Cc: Paul Sokolovsky Cc: Richard Purdie Cc: Liam Girdwood Cc: Andrew Morton --- arch/arm/mach-pxa/corgi_ssp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-pxa/corgi_ssp.c b/arch/arm/mach-pxa/corgi_ssp.c index a5ee707..1d9bc11 100644 --- a/arch/arm/mach-pxa/corgi_ssp.c +++ b/arch/arm/mach-pxa/corgi_ssp.c @@ -204,7 +204,7 @@ void __init corgi_ssp_set_machinfo(struct corgissp_machinfo *machinfo) ssp_machinfo = machinfo; } -static int __init corgi_ssp_probe(struct platform_device *dev) +static int __devinit corgi_ssp_probe(struct platform_device *dev) { int ret; -- 1.6.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/