Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752797Ab0AYCYX (ORCPT ); Sun, 24 Jan 2010 21:24:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751800Ab0AYCYV (ORCPT ); Sun, 24 Jan 2010 21:24:21 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:51680 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751261Ab0AYCYI (ORCPT ); Sun, 24 Jan 2010 21:24:08 -0500 Date: Mon, 25 Jan 2010 00:23:51 -0200 From: Arnaldo Carvalho de Melo To: Hitoshi Mitake Cc: Ingo Molnar , linux-kernel@vger.kernel.org, =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , Mike Galbraith , Peter Zijlstra , Paul Mackerras Subject: Re: [PATCH 12/12] Revert "perf record: Intercept all events" Message-ID: <20100125022351.GD24418@ghostprotocols.net> References: <1264167553-6510-1-git-send-email-mitake@dcl.info.waseda.ac.jp> <1264167553-6510-13-git-send-email-mitake@dcl.info.waseda.ac.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1264167553-6510-13-git-send-email-mitake@dcl.info.waseda.ac.jp> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1370 Lines: 34 Em Fri, Jan 22, 2010 at 10:39:13PM +0900, Hitoshi Mitake escreveu: > This reverts commit f5a2c3dce03621b55f84496f58adc2d1a87ca16f. > > This patch is required for making "perf lock rec" work. > The commit f5a2c3dce0 changes write_event() of builtin-record.c . > And changed write_event() sometimes doesn't stop with perf lock rec. > > I'm researching what makes write_event() loop infinity, > and noticed that there are some events with event_t->header.size == 0. > But the detail of the problem, > like kind of these events, isn't clear... > > If you know something related to this problem, > could you tell me, Arnaldo? Well, this will have to wait for somebody to remove the need for intercepting those events, reverting this patch fixes your tool while breaking others that then won't catch all the events. I'll get 'perf regtest' out with some initial tests then try to get some proposal for injecting the buildid, if found in a DSO, via PERF_RECORD_MMAP, lets see how this goes... Best Regards, - Arnaldo BTW: I took longer to send a response to this question addressed to me because I wasn't on the CC list :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/