DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=V88yxmNl9lnGJ2RA4gEcqYCJsFuNyAD0xBiNcE0OIMhmc0p5QcuZPtR3VehbLh+u8D
         15dBU8/FkCfzKc47CN+cNN4A/ALmsdX4uCj0DoKLQVSBddrBf11Eyedg2bgH+HHJTtlN
         TcjA4OYGkSip9W7PYOjuN50qrBqhKMkWz5Cvc=
MIME-Version: 1.0
In-Reply-To: <20100112115156.GA546@rakim.wolfsonmicro.main>
References: <771cded01001120041ue24edabk8e4638ef7151c947@mail.gmail.com>
	 <771cded01001120051l44fd76bx80d2fd4b6f60bd0b@mail.gmail.com>
	 <20100112115156.GA546@rakim.wolfsonmicro.main>
Date: Mon, 25 Jan 2010 06:01:41 -0500
Message-ID: <771cded01001250301q465a9f8ma484f597ae9a292f@mail.gmail.com>
Subject: Re: [PATCH 01/01] regulator: support max8649
From: Haojian Zhuang <haojian.zhuang@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
       linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
       linux-kernel@vger.kernel.org
Content-Type: multipart/mixed; boundary=000e0cd32f161c4483047dfb18a5
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 19302
Lines: 278

--000e0cd32f161c4483047dfb18a5
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 12, 2010 at 6:51 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Tue, Jan 12, 2010 at 03:51:09AM -0500, Haojian Zhuang wrote:
>
>> Enable Maxim max8649 regulator driver.
>
> This seems basically fine but there's a few relatively minor issues
> below, mostly coding style rather than anything serious.
>
>
>> + =A0 =A0 if (pdata->ramp_timing) {
>> + =A0 =A0 =A0 =A0 =A0 =A0 info->ramp_timing =3D pdata->ramp_timing;
>> + =A0 =A0 =A0 =A0 =A0 =A0 max8649_set_bits(info->i2c, MAX8649_RAMP, MAX8=
649_RAMP_MASK,
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0info->ramp_=
timing << 5);
>> + =A0 =A0 }
>
> You might want to implement the new enable_time() API for this.
>

This ramp timing is the time interval of each step on adjusting
voltage. I just want to control the timing in initialization.
enable_time() is only called before enabling regulator. And I don't
understand what would be done in enable_time().

Others are updated in this attached patch.

Thanks
Haojian

--000e0cd32f161c4483047dfb18a5
Content-Type: text/x-patch; charset=US-ASCII; 
	name="0001-regulator-enable-max8649-regulator-driver.patch"
Content-Disposition: attachment; 
	filename="0001-regulator-enable-max8649-regulator-driver.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g4vlvfpe0

RnJvbSA5N2RhZjVkY2FjNTA3M2JkYjkxNWVjYTBjMzllY2ViMmU3NGU3ODdmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBIYW9qaWFuIFpodWFuZyA8aGFvamlhbi56aHVhbmdAbWFydmVs
bC5jb20+CkRhdGU6IE1vbiwgMjUgSmFuIDIwMTAgMTA6MjQ6MDkgLTA1MDAKU3ViamVjdDogW1BB
VENIXSByZWd1bGF0b3I6IGVuYWJsZSBtYXg4NjQ5IHJlZ3VsYXRvciBkcml2ZXIKClNpZ25lZC1v
ZmYtYnk6IEhhb2ppYW4gWmh1YW5nIDxoYW9qaWFuLnpodWFuZ0BtYXJ2ZWxsLmNvbT4KLS0tCiBk
cml2ZXJzL3JlZ3VsYXRvci9LY29uZmlnICAgICAgICAgfCAgICA3ICsKIGRyaXZlcnMvcmVndWxh
dG9yL01ha2VmaWxlICAgICAgICB8ICAgIDEgKwogZHJpdmVycy9yZWd1bGF0b3IvbWF4ODY0OS5j
ICAgICAgIHwgIDM4NSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiBpbmNs
dWRlL2xpbnV4L3JlZ3VsYXRvci9tYXg4NjQ5LmggfCAgIDQ0ICsrKysrCiA0IGZpbGVzIGNoYW5n
ZWQsIDQzNyBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQogY3JlYXRlIG1vZGUgMTAwNjQ0
IGRyaXZlcnMvcmVndWxhdG9yL21heDg2NDkuYwogY3JlYXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUv
bGludXgvcmVndWxhdG9yL21heDg2NDkuaAoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvcmVndWxhdG9y
L0tjb25maWcgYi9kcml2ZXJzL3JlZ3VsYXRvci9LY29uZmlnCmluZGV4IDI2MmY2MmUuLmE2ZTdh
MGMgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvcmVndWxhdG9yL0tjb25maWcKKysrIGIvZHJpdmVycy9y
ZWd1bGF0b3IvS2NvbmZpZwpAQCAtNjksNiArNjksMTMgQEAgY29uZmlnIFJFR1VMQVRPUl9NQVgx
NTg2CiAJICByZWd1bGF0b3IgdmlhIEkyQyBidXMuIFRoZSBwcm92aWRlZCByZWd1bGF0b3IgaXMg
c3VpdGFibGUKIAkgIGZvciBQWEEyN3ggY2hpcHMgdG8gY29udHJvbCBWQ0NfQ09SRSBhbmQgVkND
X1VTSU0gdm9sdGFnZXMuCiAKK2NvbmZpZyBSRUdVTEFUT1JfTUFYODY0OQorCXRyaXN0YXRlICJN
YXhpbSA4NjQ5IHZvbHRhZ2UgcmVndWxhdG9yIgorCWRlcGVuZHMgb24gSTJDCisJaGVscAorCSAg
VGhpcyBkcml2ZXIgY29udHJvbHMgYSBNYXhpbSA4NjQ5IHZvbHRhZ2Ugb3V0cHV0IHJlZ3VsYXRv
ciB2aWEKKwkgIEkyQyBidXMuCisKIGNvbmZpZyBSRUdVTEFUT1JfTUFYODY2MAogCXRyaXN0YXRl
ICJNYXhpbSA4NjYwLzg2NjEgdm9sdGFnZSByZWd1bGF0b3IiCiAJZGVwZW5kcyBvbiBJMkMKZGlm
ZiAtLWdpdCBhL2RyaXZlcnMvcmVndWxhdG9yL01ha2VmaWxlIGIvZHJpdmVycy9yZWd1bGF0b3Iv
TWFrZWZpbGUKaW5kZXggYjNjODA2Yy4uMDc1ODM1YiAxMDA2NDQKLS0tIGEvZHJpdmVycy9yZWd1
bGF0b3IvTWFrZWZpbGUKKysrIGIvZHJpdmVycy9yZWd1bGF0b3IvTWFrZWZpbGUKQEAgLTEyLDYg
KzEyLDcgQEAgb2JqLSQoQ09ORklHX1JFR1VMQVRPUl9CUTI0MDIyKSArPSBicTI0MDIyLm8KIG9i
ai0kKENPTkZJR19SRUdVTEFUT1JfTFAzOTcxKSArPSBscDM5NzEubwogb2JqLSQoQ09ORklHX1JF
R1VMQVRPUl9NQVgxNTg2KSArPSBtYXgxNTg2Lm8KIG9iai0kKENPTkZJR19SRUdVTEFUT1JfVFdM
NDAzMCkgKz0gdHdsLXJlZ3VsYXRvci5vCitvYmotJChDT05GSUdfUkVHVUxBVE9SX01BWDg2NDkp
CSs9IG1heDg2NDkubwogb2JqLSQoQ09ORklHX1JFR1VMQVRPUl9NQVg4NjYwKSArPSBtYXg4NjYw
Lm8KIG9iai0kKENPTkZJR19SRUdVTEFUT1JfV004MzFYKSArPSB3bTgzMXgtZGNkYy5vCiBvYmot
JChDT05GSUdfUkVHVUxBVE9SX1dNODMxWCkgKz0gd204MzF4LWlzaW5rLm8KZGlmZiAtLWdpdCBh
L2RyaXZlcnMvcmVndWxhdG9yL21heDg2NDkuYyBiL2RyaXZlcnMvcmVndWxhdG9yL21heDg2NDku
YwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5hODNlODgyCi0tLSAvZGV2L251
bGwKKysrIGIvZHJpdmVycy9yZWd1bGF0b3IvbWF4ODY0OS5jCkBAIC0wLDAgKzEsMzg1IEBACisv
KgorICogUmVndWxhdG9ycyBkcml2ZXIgZm9yIE1heGltIG1heDg2NDkKKyAqCisgKiBDb3B5cmln
aHQgKEMpIDIwMDktMjAxMCBNYXJ2ZWxsIEludGVybmF0aW9uYWwgTHRkLgorICogICAgICBIYW9q
aWFuIFpodWFuZyA8aGFvamlhbi56aHVhbmdAbWFydmVsbC5jb20+CisgKgorICogVGhpcyBwcm9n
cmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2Rp
ZnkKKyAqIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vu
c2UgdmVyc2lvbiAyIGFzCisgKiBwdWJsaXNoZWQgYnkgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRh
dGlvbi4KKyAqLworI2luY2x1ZGUgPGxpbnV4L2tlcm5lbC5oPgorI2luY2x1ZGUgPGxpbnV4L21v
ZHVsZS5oPgorI2luY2x1ZGUgPGxpbnV4L2Vyci5oPgorI2luY2x1ZGUgPGxpbnV4L2kyYy5oPgor
I2luY2x1ZGUgPGxpbnV4L3BsYXRmb3JtX2RldmljZS5oPgorI2luY2x1ZGUgPGxpbnV4L3JlZ3Vs
YXRvci9kcml2ZXIuaD4KKyNpbmNsdWRlIDxsaW51eC9yZWd1bGF0b3IvbWF4ODY0OS5oPgorCisj
ZGVmaW5lIE1BWDg2NDlfRENEQ19WTUlOCTc1MDAwMAkJLyogdVYgKi8KKyNkZWZpbmUgTUFYODY0
OV9EQ0RDX1ZNQVgJMTM4MDAwMAkJLyogdVYgKi8KKyNkZWZpbmUgTUFYODY0OV9EQ0RDX1NURVAJ
MTAwMDAJCS8qIHVWICovCisjZGVmaW5lIE1BWDg2NDlfVk9MX01BU0sJMHgzZgorCisvKiBSZWdp
c3RlcnMgKi8KKyNkZWZpbmUgTUFYODY0OV9NT0RFMAkJMHgwMAorI2RlZmluZSBNQVg4NjQ5X01P
REUxCQkweDAxCisjZGVmaW5lIE1BWDg2NDlfTU9ERTIJCTB4MDIKKyNkZWZpbmUgTUFYODY0OV9N
T0RFMwkJMHgwMworI2RlZmluZSBNQVg4NjQ5X0NPTlRST0wJCTB4MDQKKyNkZWZpbmUgTUFYODY0
OV9TWU5DCQkweDA1CisjZGVmaW5lIE1BWDg2NDlfUkFNUAkJMHgwNgorI2RlZmluZSBNQVg4NjQ5
X0NISVBfSUQxCTB4MDgKKyNkZWZpbmUgTUFYODY0OV9DSElQX0lEMgkweDA5CisKKy8qIEJpdHMg
Ki8KKyNkZWZpbmUgTUFYODY0OV9FTl9QRAkJKDEgPDwgNykKKyNkZWZpbmUgTUFYODY0OV9WSUQw
X1BECQkoMSA8PCA2KQorI2RlZmluZSBNQVg4NjQ5X1ZJRDFfUEQJCSgxIDw8IDUpCisjZGVmaW5l
IE1BWDg2NDlfVklEX01BU0sJKDMgPDwgNSkKKworI2RlZmluZSBNQVg4NjQ5X0ZPUkNFX1BXTQko
MSA8PCA3KQorI2RlZmluZSBNQVg4NjQ5X1NZTkNfRVhUQ0xLCSgxIDw8IDYpCisKKyNkZWZpbmUg
TUFYODY0OV9FWFRfTUFTSwkoMyA8PCA2KQorCisjZGVmaW5lIE1BWDg2NDlfUkFNUF9NQVNLCSg3
IDw8IDUpCisjZGVmaW5lIE1BWDg2NDlfUkFNUF9ET1dOCSgxIDw8IDEpCisKK3N0cnVjdCBtYXg4
NjQ5X3JlZ3VsYXRvcl9pbmZvIHsKKwlzdHJ1Y3QgcmVndWxhdG9yX2RldgkqcmVndWxhdG9yOwor
CXN0cnVjdCBpMmNfY2xpZW50CSppMmM7CisJc3RydWN0IGRldmljZQkJKmRldjsKKwlzdHJ1Y3Qg
bXV0ZXgJCWlvX2xvY2s7CisKKwlpbnQJCXZvbF9yZWc7CisJdW5zaWduZWQJbW9kZToyOwkvKiBi
aXRbMTowXSA9IFZJRDEsIFZJRDAgKi8KKwl1bnNpZ25lZAlleHRjbGtfZnJlcToyOworCXVuc2ln
bmVkCWV4dGNsazoxOworCXVuc2lnbmVkCXJhbXBfdGltaW5nOjM7CisJdW5zaWduZWQJcmFtcF9k
b3duOjE7Cit9OworCisvKiBJMkMgb3BlcmF0aW9ucyAqLworCitzdGF0aWMgaW5saW5lIGludCBt
YXg4NjQ5X3JlYWRfZGV2aWNlKHN0cnVjdCBpMmNfY2xpZW50ICppMmMsCisJCQkJICAgICAgaW50
IHJlZywgaW50IGJ5dGVzLCB2b2lkICpkZXN0KQoreworCXVuc2lnbmVkIGNoYXIgZGF0YTsKKwlp
bnQgcmV0OworCisJZGF0YSA9ICh1bnNpZ25lZCBjaGFyKXJlZzsKKwlyZXQgPSBpMmNfbWFzdGVy
X3NlbmQoaTJjLCAmZGF0YSwgMSk7CisJaWYgKHJldCA8IDApCisJCXJldHVybiByZXQ7CisJcmV0
ID0gaTJjX21hc3Rlcl9yZWN2KGkyYywgZGVzdCwgYnl0ZXMpOworCWlmIChyZXQgPCAwKQorCQly
ZXR1cm4gcmV0OworCXJldHVybiAwOworfQorCitzdGF0aWMgaW5saW5lIGludCBtYXg4NjQ5X3dy
aXRlX2RldmljZShzdHJ1Y3QgaTJjX2NsaWVudCAqaTJjLAorCQkJCSAgICAgICBpbnQgcmVnLCBp
bnQgYnl0ZXMsIHZvaWQgKnNyYykKK3sKKwl1bnNpZ25lZCBjaGFyIGJ1ZltieXRlcyArIDFdOwor
CWludCByZXQ7CisKKwlidWZbMF0gPSAodW5zaWduZWQgY2hhcilyZWc7CisJbWVtY3B5KCZidWZb
MV0sIHNyYywgYnl0ZXMpOworCisJcmV0ID0gaTJjX21hc3Rlcl9zZW5kKGkyYywgYnVmLCBieXRl
cyArIDEpOworCWlmIChyZXQgPCAwKQorCQlyZXR1cm4gcmV0OworCXJldHVybiAwOworfQorCitz
dGF0aWMgaW50IG1heDg2NDlfcmVnX3JlYWQoc3RydWN0IGkyY19jbGllbnQgKmkyYywgaW50IHJl
ZykKK3sKKwlzdHJ1Y3QgbWF4ODY0OV9yZWd1bGF0b3JfaW5mbyAqaW5mbyA9IGkyY19nZXRfY2xp
ZW50ZGF0YShpMmMpOworCXVuc2lnbmVkIGNoYXIgZGF0YTsKKwlpbnQgcmV0OworCisJbXV0ZXhf
bG9jaygmaW5mby0+aW9fbG9jayk7CisJcmV0ID0gbWF4ODY0OV9yZWFkX2RldmljZShpMmMsIHJl
ZywgMSwgJmRhdGEpOworCW11dGV4X3VubG9jaygmaW5mby0+aW9fbG9jayk7CisKKwlpZiAocmV0
IDwgMCkKKwkJcmV0dXJuIHJldDsKKwlyZXR1cm4gKGludClkYXRhOworfQorCitzdGF0aWMgaW50
IG1heDg2NDlfc2V0X2JpdHMoc3RydWN0IGkyY19jbGllbnQgKmkyYywgaW50IHJlZywKKwkJCSAg
ICB1bnNpZ25lZCBjaGFyIG1hc2ssIHVuc2lnbmVkIGNoYXIgZGF0YSkKK3sKKwlzdHJ1Y3QgbWF4
ODY0OV9yZWd1bGF0b3JfaW5mbyAqaW5mbyA9IGkyY19nZXRfY2xpZW50ZGF0YShpMmMpOworCXVu
c2lnbmVkIGNoYXIgdmFsdWU7CisJaW50IHJldDsKKworCW11dGV4X2xvY2soJmluZm8tPmlvX2xv
Y2spOworCXJldCA9IG1heDg2NDlfcmVhZF9kZXZpY2UoaTJjLCByZWcsIDEsICZ2YWx1ZSk7CisJ
aWYgKHJldCA8IDApCisJCWdvdG8gb3V0OworCXZhbHVlICY9IH5tYXNrOworCXZhbHVlIHw9IGRh
dGE7CisJcmV0ID0gbWF4ODY0OV93cml0ZV9kZXZpY2UoaTJjLCByZWcsIDEsICZ2YWx1ZSk7Citv
dXQ6CisJbXV0ZXhfdW5sb2NrKCZpbmZvLT5pb19sb2NrKTsKKwlyZXR1cm4gcmV0OworfQorCitz
dGF0aWMgaW5saW5lIGludCBjaGVja19yYW5nZShpbnQgbWluX3VWLCBpbnQgbWF4X3VWKQorewor
CWlmICgobWluX3VWIDwgTUFYODY0OV9EQ0RDX1ZNSU4pIHx8IChtYXhfdVYgPiBNQVg4NjQ5X0RD
RENfVk1BWCkKKwkJfHwgKG1pbl91ViA+IG1heF91VikpCisJCXJldHVybiAtRUlOVkFMOworCXJl
dHVybiAwOworfQorCitzdGF0aWMgaW50IG1heDg2NDlfbGlzdF92b2x0YWdlKHN0cnVjdCByZWd1
bGF0b3JfZGV2ICpyZGV2LCB1bnNpZ25lZCBpbmRleCkKK3sKKwlyZXR1cm4gKE1BWDg2NDlfRENE
Q19WTUlOICsgaW5kZXggKiBNQVg4NjQ5X0RDRENfU1RFUCk7Cit9CisKK3N0YXRpYyBpbnQgbWF4
ODY0OV9nZXRfdm9sdGFnZShzdHJ1Y3QgcmVndWxhdG9yX2RldiAqcmRldikKK3sKKwlzdHJ1Y3Qg
bWF4ODY0OV9yZWd1bGF0b3JfaW5mbyAqaW5mbyA9IHJkZXZfZ2V0X2RydmRhdGEocmRldik7CisJ
dW5zaWduZWQgY2hhciBkYXRhOworCWludCByZXQ7CisKKwlyZXQgPSBtYXg4NjQ5X3JlZ19yZWFk
KGluZm8tPmkyYywgaW5mby0+dm9sX3JlZyk7CisJaWYgKHJldCA8IDApCisJCXJldHVybiByZXQ7
CisJZGF0YSA9ICh1bnNpZ25lZCBjaGFyKXJldCAmIE1BWDg2NDlfVk9MX01BU0s7CisJcmV0dXJu
IChtYXg4NjQ5X2xpc3Rfdm9sdGFnZShyZGV2LCBkYXRhKSk7Cit9CisKK3N0YXRpYyBpbnQgbWF4
ODY0OV9zZXRfdm9sdGFnZShzdHJ1Y3QgcmVndWxhdG9yX2RldiAqcmRldiwKKwkJCSAgICAgICBp
bnQgbWluX3VWLCBpbnQgbWF4X3VWKQoreworCXN0cnVjdCBtYXg4NjQ5X3JlZ3VsYXRvcl9pbmZv
ICppbmZvID0gcmRldl9nZXRfZHJ2ZGF0YShyZGV2KTsKKwl1bnNpZ25lZCBjaGFyIGRhdGEsIG1h
c2s7CisKKwlpZiAoY2hlY2tfcmFuZ2UobWluX3VWLCBtYXhfdVYpKSB7CisJCWRldl9lcnIoaW5m
by0+ZGV2LCAiaW52YWxpZCB2b2x0YWdlIHJhbmdlICglZCwgJWQpIHVWXG4iLAorCQkJbWluX3VW
LCBtYXhfdVYpOworCQlyZXR1cm4gLUVJTlZBTDsKKwl9CisJZGF0YSA9IChtaW5fdVYgLSBNQVg4
NjQ5X0RDRENfVk1JTiArIE1BWDg2NDlfRENEQ19TVEVQIC0gMSkKKwkJLyBNQVg4NjQ5X0RDRENf
U1RFUDsKKwltYXNrID0gTUFYODY0OV9WT0xfTUFTSzsKKworCXJldHVybiBtYXg4NjQ5X3NldF9i
aXRzKGluZm8tPmkyYywgaW5mby0+dm9sX3JlZywgbWFzaywgZGF0YSk7Cit9CisKKy8qIEVOX1BE
IG1lYW5zIHB1bGxkb3duIG9uIEVOIGlucHV0ICovCitzdGF0aWMgaW50IG1heDg2NDlfZW5hYmxl
KHN0cnVjdCByZWd1bGF0b3JfZGV2ICpyZGV2KQoreworCXN0cnVjdCBtYXg4NjQ5X3JlZ3VsYXRv
cl9pbmZvICppbmZvID0gcmRldl9nZXRfZHJ2ZGF0YShyZGV2KTsKKwlyZXR1cm4gbWF4ODY0OV9z
ZXRfYml0cyhpbmZvLT5pMmMsIE1BWDg2NDlfQ09OVFJPTCwgTUFYODY0OV9FTl9QRCwgMCk7Cit9
CisKKy8qCisgKiBBcHBsaWVkIGludGVybmFsIHB1bGxkb3duIHJlc2lzdG9yIG9uIEVOIGlucHV0
IHBpbi4KKyAqIElmIHB1bGxkb3duIEVOIHBpbiBvdXRzaWRlLCBpdCB3b3VsZCBiZSBiZXR0ZXIu
CisgKi8KK3N0YXRpYyBpbnQgbWF4ODY0OV9kaXNhYmxlKHN0cnVjdCByZWd1bGF0b3JfZGV2ICpy
ZGV2KQoreworCXN0cnVjdCBtYXg4NjQ5X3JlZ3VsYXRvcl9pbmZvICppbmZvID0gcmRldl9nZXRf
ZHJ2ZGF0YShyZGV2KTsKKwlyZXR1cm4gbWF4ODY0OV9zZXRfYml0cyhpbmZvLT5pMmMsIE1BWDg2
NDlfQ09OVFJPTCwgTUFYODY0OV9FTl9QRCwKKwkJCQlNQVg4NjQ5X0VOX1BEKTsKK30KKworc3Rh
dGljIGludCBtYXg4NjQ5X2lzX2VuYWJsZWQoc3RydWN0IHJlZ3VsYXRvcl9kZXYgKnJkZXYpCit7
CisJc3RydWN0IG1heDg2NDlfcmVndWxhdG9yX2luZm8gKmluZm8gPSByZGV2X2dldF9kcnZkYXRh
KHJkZXYpOworCWludCByZXQ7CisKKwlyZXQgPSBtYXg4NjQ5X3JlZ19yZWFkKGluZm8tPmkyYywg
TUFYODY0OV9DT05UUk9MKTsKKwlpZiAocmV0IDwgMCkKKwkJcmV0dXJuIHJldDsKKwlyZXR1cm4g
ISgodW5zaWduZWQgY2hhcilyZXQgJiBNQVg4NjQ5X0VOX1BEKTsKK30KKworc3RhdGljIGludCBt
YXg4NjQ5X3NldF9tb2RlKHN0cnVjdCByZWd1bGF0b3JfZGV2ICpyZGV2LCB1bnNpZ25lZCBpbnQg
bW9kZSkKK3sKKwlzdHJ1Y3QgbWF4ODY0OV9yZWd1bGF0b3JfaW5mbyAqaW5mbyA9IHJkZXZfZ2V0
X2RydmRhdGEocmRldik7CisKKwlzd2l0Y2ggKG1vZGUpIHsKKwljYXNlIFJFR1VMQVRPUl9NT0RF
X0ZBU1Q6CisJY2FzZSBSRUdVTEFUT1JfTU9ERV9OT1JNQUw6CisJCW1heDg2NDlfc2V0X2JpdHMo
aW5mby0+aTJjLCBpbmZvLT52b2xfcmVnLCBNQVg4NjQ5X0ZPUkNFX1BXTSwKKwkJCQkgTUFYODY0
OV9GT1JDRV9QV00pOworCQlicmVhazsKKwljYXNlIFJFR1VMQVRPUl9NT0RFX0lETEU6CisJY2Fz
ZSBSRUdVTEFUT1JfTU9ERV9TVEFOREJZOgorCQltYXg4NjQ5X3NldF9iaXRzKGluZm8tPmkyYywg
aW5mby0+dm9sX3JlZywKKwkJCQkgTUFYODY0OV9GT1JDRV9QV00sIDApOworCQlicmVhazsKKwl9
CisJcmV0dXJuIDA7Cit9CisKK3N0YXRpYyB1bnNpZ25lZCBpbnQgbWF4ODY0OV9nZXRfbW9kZShz
dHJ1Y3QgcmVndWxhdG9yX2RldiAqcmRldikKK3sKKwlzdHJ1Y3QgbWF4ODY0OV9yZWd1bGF0b3Jf
aW5mbyAqaW5mbyA9IHJkZXZfZ2V0X2RydmRhdGEocmRldik7CisJaW50IHJldDsKKworCXJldCA9
IG1heDg2NDlfcmVnX3JlYWQoaW5mby0+aTJjLCBpbmZvLT52b2xfcmVnKTsKKwlpZiAocmV0ICYg
TUFYODY0OV9GT1JDRV9QV00pCisJCXJldHVybiBSRUdVTEFUT1JfTU9ERV9OT1JNQUw7CisJcmV0
dXJuIFJFR1VMQVRPUl9NT0RFX0lETEU7Cit9CisKK3N0YXRpYyBzdHJ1Y3QgcmVndWxhdG9yX29w
cyBtYXg4NjQ5X2RjZGNfb3BzID0geworCS5zZXRfdm9sdGFnZQk9IG1heDg2NDlfc2V0X3ZvbHRh
Z2UsCisJLmdldF92b2x0YWdlCT0gbWF4ODY0OV9nZXRfdm9sdGFnZSwKKwkubGlzdF92b2x0YWdl
CT0gbWF4ODY0OV9saXN0X3ZvbHRhZ2UsCisJLmVuYWJsZQkJPSBtYXg4NjQ5X2VuYWJsZSwKKwku
ZGlzYWJsZQk9IG1heDg2NDlfZGlzYWJsZSwKKwkuaXNfZW5hYmxlZAk9IG1heDg2NDlfaXNfZW5h
YmxlZCwKKwkuc2V0X21vZGUJPSBtYXg4NjQ5X3NldF9tb2RlLAorCS5nZXRfbW9kZQk9IG1heDg2
NDlfZ2V0X21vZGUsCisKK307CisKK3N0YXRpYyBzdHJ1Y3QgcmVndWxhdG9yX2Rlc2MgZGNkY19k
ZXNjID0geworCS5uYW1lCQk9ICJtYXg4NjQ5IiwKKwkub3BzCQk9ICZtYXg4NjQ5X2RjZGNfb3Bz
LAorCS50eXBlCQk9IFJFR1VMQVRPUl9WT0xUQUdFLAorCS5uX3ZvbHRhZ2VzCT0gMSA8PCA2LAor
CS5vd25lcgkJPSBUSElTX01PRFVMRSwKK307CisKK3N0YXRpYyBpbnQgX19kZXZpbml0IG1heDg2
NDlfcmVndWxhdG9yX3Byb2JlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQsCisJCQkJCSAgICAg
Y29uc3Qgc3RydWN0IGkyY19kZXZpY2VfaWQgKmlkKQoreworCXN0cnVjdCBtYXg4NjQ5X3BsYXRm
b3JtX2RhdGEgKnBkYXRhID0gY2xpZW50LT5kZXYucGxhdGZvcm1fZGF0YTsKKwlzdHJ1Y3QgbWF4
ODY0OV9yZWd1bGF0b3JfaW5mbyAqaW5mbyA9IE5VTEw7CisJdW5zaWduZWQgY2hhciBkYXRhOwor
CWludCByZXQ7CisKKwlpbmZvID0ga3phbGxvYyhzaXplb2Yoc3RydWN0IG1heDg2NDlfcmVndWxh
dG9yX2luZm8pLCBHRlBfS0VSTkVMKTsKKwlpZiAoIWluZm8pIHsKKwkJZGV2X2VycigmY2xpZW50
LT5kZXYsICJObyBlbm91Z2ggbWVtb3J5XG4iKTsKKwkJcmV0dXJuIC1FTk9NRU07CisJfQorCisJ
aW5mby0+aTJjID0gY2xpZW50OworCWluZm8tPmRldiA9ICZjbGllbnQtPmRldjsKKwltdXRleF9p
bml0KCZpbmZvLT5pb19sb2NrKTsKKwlpMmNfc2V0X2NsaWVudGRhdGEoY2xpZW50LCBpbmZvKTsK
KworCWluZm8tPm1vZGUgPSBwZGF0YS0+bW9kZTsKKwlzd2l0Y2ggKGluZm8tPm1vZGUpIHsKKwlj
YXNlIDA6CisJCWluZm8tPnZvbF9yZWcgPSBNQVg4NjQ5X01PREUwOworCQlicmVhazsKKwljYXNl
IDE6CisJCWluZm8tPnZvbF9yZWcgPSBNQVg4NjQ5X01PREUxOworCQlicmVhazsKKwljYXNlIDI6
CisJCWluZm8tPnZvbF9yZWcgPSBNQVg4NjQ5X01PREUyOworCQlicmVhazsKKwljYXNlIDM6CisJ
CWluZm8tPnZvbF9yZWcgPSBNQVg4NjQ5X01PREUzOworCQlicmVhazsKKwlkZWZhdWx0OgorCQli
cmVhazsKKwl9CisKKwlyZXQgPSBtYXg4NjQ5X3JlZ19yZWFkKGluZm8tPmkyYywgTUFYODY0OV9D
SElQX0lEMSk7CisJaWYgKHJldCA8IDApIHsKKwkJZGV2X2VycihpbmZvLT5kZXYsICJGYWlsZWQg
dG8gZGV0ZWN0IElEIG9mIE1BWDg2NDk6JWRcbiIsCisJCQlyZXQpOworCQlnb3RvIG91dDsKKwl9
CisJZGV2X2luZm8oaW5mby0+ZGV2LCAiRGV0ZWN0ZWQgTUFYODY0OSAoSUQ6JXgpXG4iLCByZXQp
OworCisJLyogZW5hYmxlIFZJRDAgJiBWSUQxICovCisJbWF4ODY0OV9zZXRfYml0cyhpbmZvLT5p
MmMsIE1BWDg2NDlfQ09OVFJPTCwgTUFYODY0OV9WSURfTUFTSywgMCk7CisKKwkvKiBlbmFibGUv
ZGlzYWJsZSBleHRlcm5hbCBjbG9jayBzeW5jaHJvbml6YXRpb24gKi8KKwlpbmZvLT5leHRjbGsg
PSBwZGF0YS0+ZXh0Y2xrOworCWRhdGEgPSAoaW5mby0+ZXh0Y2xrKSA/IE1BWDg2NDlfU1lOQ19F
WFRDTEsgOiAwOworCW1heDg2NDlfc2V0X2JpdHMoaW5mby0+aTJjLCBpbmZvLT52b2xfcmVnLCBN
QVg4NjQ5X1NZTkNfRVhUQ0xLLCBkYXRhKTsKKwlpZiAoaW5mby0+ZXh0Y2xrKSB7CisJCS8qIHNl
dCBleHRlcm5hbCBjbG9jayBmcmVxdWVuY3kgKi8KKwkJaW5mby0+ZXh0Y2xrX2ZyZXEgPSBwZGF0
YS0+ZXh0Y2xrX2ZyZXE7CisJCW1heDg2NDlfc2V0X2JpdHMoaW5mby0+aTJjLCBNQVg4NjQ5X1NZ
TkMsIE1BWDg2NDlfRVhUX01BU0ssCisJCQkJIGluZm8tPmV4dGNsa19mcmVxKTsKKwl9CisKKwlp
ZiAocGRhdGEtPnJhbXBfdGltaW5nKSB7CisJCWluZm8tPnJhbXBfdGltaW5nID0gcGRhdGEtPnJh
bXBfdGltaW5nOworCQltYXg4NjQ5X3NldF9iaXRzKGluZm8tPmkyYywgTUFYODY0OV9SQU1QLCBN
QVg4NjQ5X1JBTVBfTUFTSywKKwkJCQkgaW5mby0+cmFtcF90aW1pbmcgPDwgNSk7CisJfQorCisJ
aW5mby0+cmFtcF9kb3duID0gcGRhdGEtPnJhbXBfZG93bjsKKwlpZiAoaW5mby0+cmFtcF9kb3du
KSB7CisJCW1heDg2NDlfc2V0X2JpdHMoaW5mby0+aTJjLCBNQVg4NjQ5X1JBTVAsIE1BWDg2NDlf
UkFNUF9ET1dOLAorCQkJCSBNQVg4NjQ5X1JBTVBfRE9XTik7CisJfQorCisJaW5mby0+cmVndWxh
dG9yID0gcmVndWxhdG9yX3JlZ2lzdGVyKCZkY2RjX2Rlc2MsICZjbGllbnQtPmRldiwKKwkJCQkJ
ICAgICBwZGF0YS0+cmVndWxhdG9yLCBpbmZvKTsKKwlpZiAoSVNfRVJSKGluZm8tPnJlZ3VsYXRv
cikpIHsKKwkJZGV2X2VycihpbmZvLT5kZXYsICJmYWlsZWQgdG8gcmVnaXN0ZXIgcmVndWxhdG9y
ICVzXG4iLAorCQkJZGNkY19kZXNjLm5hbWUpOworCQlyZXQgPSBQVFJfRVJSKGluZm8tPnJlZ3Vs
YXRvcik7CisJCWdvdG8gb3V0OworCX0KKworCWRldl9pbmZvKGluZm8tPmRldiwgIk1heDg2NDkg
cmVndWxhdG9yIGRldmljZSBpcyBkZXRlY3RlZC5cbiIpOworCXJldHVybiAwOworb3V0OgorCWtm
cmVlKGluZm8pOworCXJldHVybiByZXQ7Cit9CisKK3N0YXRpYyBpbnQgX19kZXZleGl0IG1heDg2
NDlfcmVndWxhdG9yX3JlbW92ZShzdHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50KQoreworCXN0cnVj
dCBtYXg4NjQ5X3JlZ3VsYXRvcl9pbmZvICppbmZvID0gaTJjX2dldF9jbGllbnRkYXRhKGNsaWVu
dCk7CisKKwlpZiAoaW5mbykgeworCQlpZiAoaW5mby0+cmVndWxhdG9yKQorCQkJcmVndWxhdG9y
X3VucmVnaXN0ZXIoaW5mby0+cmVndWxhdG9yKTsKKwkJa2ZyZWUoaW5mbyk7CisJfQorCWkyY19z
ZXRfY2xpZW50ZGF0YShjbGllbnQsIE5VTEwpOworCisJcmV0dXJuIDA7Cit9CisKK3N0YXRpYyBj
b25zdCBzdHJ1Y3QgaTJjX2RldmljZV9pZCBtYXg4NjQ5X2lkW10gPSB7CisJeyAibWF4ODY0OSIs
IDAgfSwKKwl7IH0KK307CitNT0RVTEVfREVWSUNFX1RBQkxFKGkyYywgbWF4ODY0OV9pZCk7CisK
K3N0YXRpYyBzdHJ1Y3QgaTJjX2RyaXZlciBtYXg4NjQ5X2RyaXZlciA9IHsKKwkucHJvYmUJCT0g
bWF4ODY0OV9yZWd1bGF0b3JfcHJvYmUsCisJLnJlbW92ZQkJPSBfX2RldmV4aXRfcChtYXg4NjQ5
X3JlZ3VsYXRvcl9yZW1vdmUpLAorCS5kcml2ZXIJCT0geworCQkubmFtZQk9ICJtYXg4NjQ5IiwK
Kwl9LAorCS5pZF90YWJsZQk9IG1heDg2NDlfaWQsCit9OworCitzdGF0aWMgaW50IF9faW5pdCBt
YXg4NjQ5X2luaXQodm9pZCkKK3sKKwlyZXR1cm4gaTJjX2FkZF9kcml2ZXIoJm1heDg2NDlfZHJp
dmVyKTsKK30KK3N1YnN5c19pbml0Y2FsbChtYXg4NjQ5X2luaXQpOworCitzdGF0aWMgdm9pZCBf
X2V4aXQgbWF4ODY0OV9leGl0KHZvaWQpCit7CisJaTJjX2RlbF9kcml2ZXIoJm1heDg2NDlfZHJp
dmVyKTsKK30KK21vZHVsZV9leGl0KG1heDg2NDlfZXhpdCk7CisKKy8qIE1vZHVsZSBpbmZvcm1h
dGlvbiAqLworTU9EVUxFX0RFU0NSSVBUSU9OKCJNQVhJTSA4NjQ5IHZvbHRhZ2UgcmVndWxhdG9y
IGRyaXZlciIpOworTU9EVUxFX0FVVEhPUigiSGFvamlhbiBaaHVhbmcgPGhhb2ppYW4uemh1YW5n
QG1hcnZlbGwuY29tPiIpOworTU9EVUxFX0xJQ0VOU0UoIkdQTCIpOworCmRpZmYgLS1naXQgYS9p
bmNsdWRlL2xpbnV4L3JlZ3VsYXRvci9tYXg4NjQ5LmggYi9pbmNsdWRlL2xpbnV4L3JlZ3VsYXRv
ci9tYXg4NjQ5LmgKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNDE3ZDE0ZQot
LS0gL2Rldi9udWxsCisrKyBiL2luY2x1ZGUvbGludXgvcmVndWxhdG9yL21heDg2NDkuaApAQCAt
MCwwICsxLDQ0IEBACisvKgorICogSW50ZXJmYWNlIG9mIE1heGltIG1heDg2NDkKKyAqCisgKiBD
b3B5cmlnaHQgKEMpIDIwMDktMjAxMCBNYXJ2ZWxsIEludGVybmF0aW9uYWwgTHRkLgorICogICAg
ICBIYW9qaWFuIFpodWFuZyA8aGFvamlhbi56aHVhbmdAbWFydmVsbC5jb20+CisgKgorICogVGhp
cyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9v
ciBtb2RpZnkKKyAqIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGlj
IExpY2Vuc2UgdmVyc2lvbiAyIGFzCisgKiBwdWJsaXNoZWQgYnkgdGhlIEZyZWUgU29mdHdhcmUg
Rm91bmRhdGlvbi4KKyAqLworCisjaWZuZGVmIF9fTElOVVhfUkVHVUxBVE9SX01BWDg2NDlfSAor
I2RlZmluZQlfX0xJTlVYX1JFR1VMQVRPUl9NQVg4NjQ5X0gKKworI2luY2x1ZGUgPGxpbnV4L3Jl
Z3VsYXRvci9tYWNoaW5lLmg+CisKK2VudW0geworCU1BWDg2NDlfRVhUQ0xLXzI2TUhaID0gMCwK
KwlNQVg4NjQ5X0VYVENMS18xM01IWiwKKwlNQVg4NjQ5X0VYVENMS18xOU1IWiwJLyogMTkuMk1I
eiAqLworfTsKKworZW51bSB7CisJTUFYODY0OV9SQU1QXzMyTVYgPSAwLAorCU1BWDg2NDlfUkFN
UF8xNk1WLAorCU1BWDg2NDlfUkFNUF84TVYsCisJTUFYODY0OV9SQU1QXzRNViwKKwlNQVg4NjQ5
X1JBTVBfMk1WLAorCU1BWDg2NDlfUkFNUF8xTVYsCisJTUFYODY0OV9SQU1QXzBfNU1WLAorCU1B
WDg2NDlfUkFNUF8wXzI1TVYsCit9OworCitzdHJ1Y3QgbWF4ODY0OV9wbGF0Zm9ybV9kYXRhIHsK
KwlzdHJ1Y3QgcmVndWxhdG9yX2luaXRfZGF0YSAqcmVndWxhdG9yOworCisJdW5zaWduZWQJbW9k
ZToyOwkJLyogYml0WzE6MF0gPSBWSUQxLFZJRDAgKi8KKwl1bnNpZ25lZAlleHRjbGtfZnJlcToy
OworCXVuc2lnbmVkCWV4dGNsazoxOworCXVuc2lnbmVkCXJhbXBfdGltaW5nOjM7CisJdW5zaWdu
ZWQJcmFtcF9kb3duOjE7Cit9OworCisjZW5kaWYJLyogX19MSU5VWF9SRUdVTEFUT1JfTUFYODY0
OV9IICovCi0tIAoxLjUuNi41Cgo=
--000e0cd32f161c4483047dfb18a5--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/