DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:content-transfer-encoding
         :in-reply-to:user-agent;
        b=aSsPW+xYlFW6metrxrfbtu9qNPBpZX74jP8Z+tuMjt5YiQHsXZdN5tLXgCbLgCbapG
         miBgF2T1ZlY8HzWvw3BXXVJz1XpumhAfGW1QR1IbvleBmgvwZKZV4PVI1VE4tKePJkS2
         17Qj5sH2gqdYTOlrst0VyKLLt1AtvzN+U98lY=
Date: Mon, 25 Jan 2010 11:31:08 -0800
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
	<u.kleine-koenig@pengutronix.de>
Cc: Greg KH <gregkh@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform_driver_register: warn if probe is in .init.text
Message-ID: <20100125193107.GC27387@core.coreip.homeip.net>
References: <20100122173846.GA11057@suse.de>
 <1264189758-7197-1-git-send-email-u.kleine-koenig@pengutronix.de>
 <20100122234936.GA14538@core.coreip.homeip.net>
 <20100123094916.GA24949@pengutronix.de>
 <20100125171439.GA27387@core.coreip.homeip.net>
 <20100125192540.GB14834@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20100125192540.GB14834@pengutronix.de>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2119
Lines: 48

On Mon, Jan 25, 2010 at 08:25:40PM +0100, Uwe Kleine-K?nig wrote:
> Hello Dmitry,
> 
> > > > > +	if (drv->probe && kernel_init_text_address((unsigned long)drv->probe))
> > > > > +		pr_warning("oops-warning: probe function of platform driver %s"
> > > > > +			       " lives in .init.text\n", drv->driver.name);
> > > > > +#else
> > > > > +	/*
> > > > > +	 * without HOTPLUG probe functions can be discarded after the driver is
> > > > > +	 * loaded.
> > > > > +	 * There is a little chance for false positives, namely if the driver is
> > > > > +	 * registered after the .init sections are discarded.
> > > > > +	 */
> > > > > +	if (drv->probe && !kernel_init_text_address((unsigned long)drv->probe))
> > > > > +		pr_info("probably the probe function of platform driver %s can"
> > > > > +				" be moved to .init.text\n", drv->driver.name);
> > > > 
> > > > It really depends on the user's (or rather builder's) local
> > > > configuration so how can we make this suggestion?
> > > Can you point out a situation that makes the suggestion wrong?  AFAIK
> > > there only the possibility that the driver is loaded after .init is
> > > discarded (as written in the comment).
> > > 
> > 
> > The presence of CONFIG_HOTPLUG depends on particular .config, so, for
> > example, you may not have it set while I have. So you will boot, get the
> > suggestion, submit a patch, then I will boot and will get a warning that
> > the probe function is in wrong section.
> > 
> > So in general I wonder if it is possible to request that all probe
> > functions are marked as __devinit or not marked at all, regardless of
> > CONFIG_HOTPLUG and CONFIG_MODULE settings.
> Would you agree if the message would change to
> 
> 	probably the probe function of platform driver %s can be moved
> 	to .devinit.text
> 
> ?

How about "Consider marking the probe function as '__devinit'"?

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/