DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=Knt/INWGjXijf7EU1umQ/uuNCe9oHIkz7vnNuXOVtKGpgA+LJUhhR0njtOf6YOjQ8I
         Vufu01+gufgsgCo+c83vqQ6Sqm2xpENbJtyExvs6B7RKBwRH2nGf3Qyoc41LWv46Pa4c
         YBGL5MvZZeX8H4Si6SawLbVueW/tM/7tZZ/Go=
Date: Mon, 25 Jan 2010 14:15:20 -0800
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Vojtech Pavlik <vojtech@suse.cz>, Robert Hancock <hancockrwd@gmail.com>,
       Bastien Nocera <hadess@hadess.net>,
       linux-kernel <linux-kernel@vger.kernel.org>, pjones@redhat.com
Subject: Re: [PATCH] Disable i8042 checks on Intel Apple Macs
Message-ID: <20100125221520.GA30307@core.coreip.homeip.net>
References: <1264011793.1735.3683.camel@localhost.localdomain>
 <4B57A2D4.9030204@gmail.com>
 <20100121185544.GB11996@core.coreip.homeip.net>
 <51f3faa71001211339t4652700ct34659c37479cd67e@mail.gmail.com>
 <20100121221701.GA15293@core.coreip.homeip.net>
 <20100125163433.GB31957@suse.cz>
 <4B5E0DFA.8080705@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B5E0DFA.8080705@zytor.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1384
Lines: 35

On Mon, Jan 25, 2010 at 01:32:42PM -0800, H. Peter Anvin wrote:
> On 01/25/2010 08:34 AM, Vojtech Pavlik wrote:
> > 
> > Thus I believe that the right fix here is to figure out why the accesses
> > to the ports 0x60/0x64 take a long time or forever on a Mac. Is it just
> > that the kernel is timing out waiting for the i8042? Or is it something
> > more sinister?
> > 
> 
> In the A20 code in the setup code, I look for 0xFF coming back and
> terminate the "wait for ready" loop much sooner than for other values.
> 0xFF is a *possible* status value, but not a very *likely* one
> (especially for repeated reads), as it would represent:
> 
> parity error + receive timeout + transmit timeout + keyboard lock +
> command + selftest OK + input full + output full.
> 

You allow up to 32 0xFFs while i8042 driver does maximum 16 reads of
whatever - if OBF is still raised we assume i8042 is not there. Does
that mean that reads from 0x60 is what hurts on Macs?

Bastien, could you try modifying drivers/input/serio/i8042.c::
i8042_flush() to not call i8042_read_data() when str is 0xff and see if
it helps with lockups?

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/