Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752890Ab0AZHXx (ORCPT ); Tue, 26 Jan 2010 02:23:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752412Ab0AZHXw (ORCPT ); Tue, 26 Jan 2010 02:23:52 -0500 Received: from mail-qy0-f204.google.com ([209.85.221.204]:38697 "EHLO mail-qy0-f204.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752110Ab0AZHXv (ORCPT ); Tue, 26 Jan 2010 02:23:51 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=QQTizp673ikJQXr3RFxU9ixldT1bhPrujhsIAc4cheuDmNy4cZA4UnUUU/zdXiIFUm DQNNf87MnwjK03Zh5/17wtMZ3d4ZCkNb8vq6D3+ba74vKL/8s7lguhECwxuIsNCmufWy CStgIXjJbR/GrBuSieVmT9XLdpdGikmk8Jn8g= MIME-Version: 1.0 In-Reply-To: <20100125145745.GE24418@ghostprotocols.net> References: <1264167553-6510-1-git-send-email-mitake@dcl.info.waseda.ac.jp> <1264167553-6510-13-git-send-email-mitake@dcl.info.waseda.ac.jp> <20100125022351.GD24418@ghostprotocols.net> <20100125145745.GE24418@ghostprotocols.net> Date: Tue, 26 Jan 2010 16:17:39 +0900 X-Google-Sender-Auth: 47e720cadfdff961 Message-ID: Subject: Re: [PATCH 12/12] Revert "perf record: Intercept all events" From: Hitoshi Mitake To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , linux-kernel@vger.kernel.org, =?ISO-8859-1?Q?Fr=E9d=E9ric_Weisbecker?= , Mike Galbraith , Peter Zijlstra , Paul Mackerras Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2487 Lines: 61 On Mon, Jan 25, 2010 at 23:57, Arnaldo Carvalho de Melo wrote: > Em Mon, Jan 25, 2010 at 11:47:40PM +0900, Hitoshi Mitake escreveu: >> On Mon, Jan 25, 2010 at 11:23, Arnaldo Carvalho de Melo >> wrote: >> > Em Fri, Jan 22, 2010 at 10:39:13PM +0900, Hitoshi Mitake escreveu: >> >> This reverts commit f5a2c3dce03621b55f84496f58adc2d1a87ca16f. >> >> >> >> This patch is required for making "perf lock rec" work. >> >> The commit f5a2c3dce0 changes write_event() of builtin-record.c . >> >> And changed write_event() sometimes doesn't stop with perf lock rec. >> >> >> >> I'm researching what makes write_event() loop infinity, >> >> and noticed that there are some events with event_t->header.size == 0. >> >> But the detail of the problem, >> >> like kind of these events, isn't clear... >> >> >> >> If you know something related to this problem, >> >> could you tell me, Arnaldo? >> > >> > Well, this will have to wait for somebody to remove the need for >> > intercepting those events, reverting this patch fixes your tool while >> > breaking others that then won't catch all the events. >> >> Yes, this patch is too egoistic thing and temporary solution. >> I have to consider and modify 'perf lock'. > > Hey, don't get me wrong, the situation is fragile, either way something > will get broken and that isn't your fault, its just that we need some > sensible and non racy way to inject the buildids at 'perf record' time. Thanks for correcting my misunderstand :) > > The way I did it, long ago, intercepting events in 'perf record' to > build a DSO list to then at 'perf record' exit to insert a table at the > perf.data file header looks too intrusive now, so we need some other way > that doesn't have this problem and its not racy. I see. I'll look some other way, too. Or if you find it, could you tell me? > >> > I'll get 'perf regtest' out with some initial tests then try to get some >> > proposal for injecting the buildid, if found in a DSO, via >> > PERF_RECORD_MMAP, lets see how this goes... >> >> What does "DSO" mean? Sorry, I'm not good at English... > > As Peter said, anything that that is on an executable MMAP. I understood :) Thanks, Peter and Arnaldo. Thanks, Hitoshi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/