Date: Tue, 26 Jan 2010 09:47:41 +0100
From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
	<u.kleine-koenig@pengutronix.de>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Greg KH <gregkh@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform_driver_register: warn if probe is in
	.init.text
Message-ID: <20100126084741.GC20792@pengutronix.de>
References: <20100122173846.GA11057@suse.de> <1264189758-7197-1-git-send-email-u.kleine-koenig@pengutronix.de> <87y6jnw6qa.fsf@devron.myhome.or.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87y6jnw6qa.fsf@devron.myhome.or.jp>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2054
Lines: 52

Hello,

On Mon, Jan 25, 2010 at 06:09:01AM +0900, OGAWA Hirofumi wrote:
> Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> writes:
> 
> > +int platform_driver_register(struct platform_driver *drv)
> > +{
> > +	int ret = __platform_driver_register(drv);
> > +
> > +#if defined(CONFIG_HOTPLUG)
> > +	/*
> > +	 * drivers that are registered by platform_driver_register
> > +	 * should not have their probe function in .init.text.  The
> > +	 * reason is that a probe can happen after .init.text is
> > +	 * discarded which then results in an oops.  The alternatives
> > +	 * are using .devinit.text for the probe function or "register"
> > +	 * with platform_driver_probe.
> > +	 */
> > +	if (drv->probe && kernel_init_text_address((unsigned long)drv->probe))
> > +		pr_warning("oops-warning: probe function of platform driver %s"
> > +			       " lives in .init.text\n", drv->driver.name);
> > +#else
> > +	/*
> > +	 * without HOTPLUG probe functions can be discarded after the driver is
> > +	 * loaded.
> > +	 * There is a little chance for false positives, namely if the driver is
> > +	 * registered after the .init sections are discarded.
> > +	 */
> > +	if (drv->probe && !kernel_init_text_address((unsigned long)drv->probe))
> > +		pr_info("probably the probe function of platform driver %s can"
> > +				" be moved to .init.text\n", drv->driver.name);
> > +#endif
> > +	return ret;
> > +}
> 
> Um..., can't we extend modpost or such one for this? I think the static
> analysis is better (assume the changing ->probe dynamically is really
> rare).
I like the idea and will look later into modpost if this can be done
there.

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-K?nig            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/